Skip to content

Commit

Permalink
[CPDNPQ-2397] Switched to using ubuntu-24.04 in CI (#2120)
Browse files Browse the repository at this point in the history
So that we can verify the pipelines work with 24.04 and solve the
deprecation warnings in GitHub
  • Loading branch information
jebw authored Jan 20, 2025
1 parent 2b3653d commit 908f332
Show file tree
Hide file tree
Showing 7 changed files with 15 additions and 15 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/backup_production_database.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ env:
jobs:
backup:
name: Backup database
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
environment:
name: ${{ inputs.environment || 'production' }}
env:
Expand Down
12 changes: 6 additions & 6 deletions .github/workflows/deploy.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,13 +24,13 @@ jobs:
all-checks-passed:
name: All checks passed
needs: [rspec]
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
steps:
- run: "echo 'Linting and tests passed, this branch is ready to be merged'"

docker:
name: Build and push Docker image
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
if: github.actor != 'dependabot[bot]' && github.event_name != 'merge_group'
outputs:
docker-image: ${{ steps.build-docker-image.outputs.image }}
Expand All @@ -49,7 +49,7 @@ jobs:
concurrency: deploy_review_${{ github.event.pull_request.number }}
if: github.actor != 'dependabot[bot]' && github.event_name == 'pull_request'
needs: [docker]
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
environment:
name: review
steps:
Expand All @@ -74,7 +74,7 @@ jobs:
deploy-staging:
name: Deploy staging
needs: [docker, all-checks-passed]
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
if: github.ref == 'refs/heads/main'
environment:
name: staging
Expand All @@ -95,7 +95,7 @@ jobs:
deploy-sandbox:
name: Deploy sandbox
needs: [deploy-staging]
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
if: github.ref == 'refs/heads/main'
environment:
name: sandbox
Expand All @@ -114,7 +114,7 @@ jobs:
deploy-production:
name: Deploy production
needs: [deploy-staging]
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
if: github.ref == 'refs/heads/main'
environment:
name: production
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/destroy_review_app.yml
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ jobs:
name: Delete Review App ${{ github.event.pull_request.number }}
concurrency: deploy_review_${{ github.event.pull_request.number }}
if: ${{ !contains(github.event.pull_request.labels.*.name, 'dependencies') }}
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
environment: review
steps:
- uses: actions/checkout@v4
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/lead_provider_openapi_check.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ jobs:
rspec:
name: Check OpenAPI schema

runs-on: ubuntu-latest
runs-on: ubuntu-24.04

env:
RAILS_ENV: test
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/maintenance.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ on:
jobs:
set-maintenance-mode:
name: Set maintenance mode
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
environment: ${{ inputs.environment }}

steps:
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/restore_azure_database.yml
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ jobs:
restore:
name: Restore AKS Database
if: ${{ inputs.environment != 'production' || (inputs.environment == 'production' && github.event.inputs.confirm-production == 'true' ) }}
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
environment: ${{ inputs.environment }}
concurrency: deploy_${{ inputs.environment }}

Expand Down
8 changes: 4 additions & 4 deletions .github/workflows/rspec.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ jobs:
name: "Lint ruby"
env:
GOVUK_NOTIFY_API_KEY: Test
runs-on: ubuntu-latest
runs-on: ubuntu-24.04

steps:
- uses: actions/checkout@v4
Expand Down Expand Up @@ -53,7 +53,7 @@ jobs:
name: "Lint SCSS"
env:
GOVUK_NOTIFY_API_KEY: Test
runs-on: ubuntu-latest
runs-on: ubuntu-24.04

steps:
- uses: actions/checkout@v4
Expand All @@ -74,7 +74,7 @@ jobs:
rspec:
name: Run Rspec

runs-on: ubuntu-latest
runs-on: ubuntu-24.04

env:
RAILS_ENV: test
Expand Down Expand Up @@ -161,7 +161,7 @@ jobs:

sonar-scanner:
name: Sonar Scanner
runs-on: ubuntu-latest
runs-on: ubuntu-24.04
needs: [ rspec, ruby_linting ]
if: github.ref != 'refs/heads/main' && github.actor != 'dependabot[bot]'
environment:
Expand Down

0 comments on commit 908f332

Please sign in to comment.