Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CPDNPQ-2423] Update dependencies #2103

Merged
merged 10 commits into from
Jan 20, 2025
Merged

[CPDNPQ-2423] Update dependencies #2103

merged 10 commits into from
Jan 20, 2025

Conversation

jebw
Copy link
Contributor

@jebw jebw commented Jan 6, 2025 •
edited
Loading

Context

Ticket: https://dfedigital.atlassian.net/browse/CPDNPQ-2423

We should keep our dependencies up to date

Changes proposed in this pull request

  1. Upgrade rails to 7.1.5.1 and lock Gemfile to Rails 7.1
  2. Upgrade other ruby dependencies
  3. Dropped redundant json_api_client gem
  4. Dropped with_model gem - can be replaced easily enough with a built activemodel class
  5. Increased flexibility in rspec-rails version requirements
  6. Upgraded assorted other gems
  7. Fixed how AxeCoreCapybara is configured for specs to work around bizarre default config in later versions of gem (see the diff from 4.6 to 4.7 - the code in set_driver makes a lot of incorrect assumptions)

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jan 6, 2025

Review app deployed to https://npq-registration-review-2103-web.test.teacherservices.cloud/

@jebw jebw force-pushed the CPDNPQ-2423-update-dependencies branch from d379c72 to 3116a3b Compare January 6, 2025 15:57
@jebw jebw force-pushed the CPDNPQ-2423-update-dependencies branch from d931580 to 40c7f4d Compare January 6, 2025 17:03
@jebw jebw force-pushed the CPDNPQ-2423-update-dependencies branch from 2fcdce9 to 148b13d Compare January 7, 2025 10:31
@jebw jebw marked this pull request as ready for review January 7, 2025 12:06
@jebw jebw requested a review from a team as a code owner January 7, 2025 12:06
@jebw jebw force-pushed the CPDNPQ-2423-update-dependencies branch from 148b13d to ae1313b Compare January 15, 2025 09:49
@jebw jebw force-pushed the CPDNPQ-2423-update-dependencies branch from ae1313b to 09ed52c Compare January 20, 2025 11:48
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@jebw jebw added this pull request to the merge queue Jan 20, 2025
Merged via the queue into main with commit 2b3653d Jan 20, 2025
18 checks passed
@jebw jebw deleted the CPDNPQ-2423-update-dependencies branch January 20, 2025 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alkesh alkesh alkesh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jebw @alkesh