Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Validate declaration_date only when its changed #2112

Merged
merged 2 commits into from
Jan 22, 2025

Conversation

slawosz
Copy link
Contributor

@slawosz slawosz commented Jan 8, 2025

declaration_date does not need to be validated when is not being changed.
https://dfedigital.atlassian.net/browse/CPDNPQ-2432

@slawosz slawosz requested a review from a team as a code owner January 8, 2025 18:45
Copy link
Contributor

github-actions bot commented Jan 8, 2025

@slawosz slawosz force-pushed the 2432-change-declaration-validation branch from 7d8a2c8 to 38456fb Compare January 8, 2025 19:34
spec/models/declaration_spec.rb Outdated Show resolved Hide resolved
Copy link
Contributor

@jebw jebw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@slawosz slawosz added this pull request to the merge queue Jan 22, 2025
Merged via the queue into main with commit c9c13d2 Jan 22, 2025
18 checks passed
@slawosz slawosz deleted the 2432-change-declaration-validation branch January 22, 2025 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants