Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CPDNPQ-2490] show Application ID on registration success page #2154

Merged
merged 1 commit into from
Jan 28, 2025
Merged

[CPDNPQ-2490] show Application ID on registration success page #2154

merged 1 commit into from
Jan 28, 2025

Conversation

alkesh
Copy link
Contributor

@alkesh alkesh commented Jan 27, 2025

Context

Ticket: https://dfedigital.atlassian.net/browse/CPDNPQ-2490

Changes proposed in this pull request

Added Application ID on the registration success page:
Screenshot 2025-01-27 at 15 37 42

@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link
Contributor

Review app deployed to https://npq-registration-review-2154-web.test.teacherservices.cloud/

@alkesh alkesh marked this pull request as ready for review January 27, 2025 16:29
@alkesh alkesh requested a review from a team as a code owner January 27, 2025 16:29
jebw
jebw approved these changes Jan 27, 2025
View reviewed changes
Copy link
Contributor

@jebw jebw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems fine but I wonder if it would look more consistent with another summary card with just the application id in?

@alkesh alkesh added this pull request to the merge queue Jan 28, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jan 28, 2025
@alkesh alkesh added this pull request to the merge queue Jan 28, 2025
Merged via the queue into main with commit d56e09f Jan 28, 2025
18 checks passed
@alkesh alkesh deleted the CPDNPQ-2490-show-application-id-on-registration-status-page branch January 28, 2025 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jebw jebw jebw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alkesh @jebw