Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow for slow file downloads in CI #2155

Merged
merged 1 commit into from
Jan 28, 2025
Merged

Allow for slow file downloads in CI #2155

merged 1 commit into from
Jan 28, 2025

Conversation

jebw
Copy link
Contributor

@jebw jebw commented Jan 27, 2025

Context

Ticket: BAU

Specs are consistently failing on main, they were not earlier today - I think this is because we're only allowing 0.1 seconds to download the file and CI is more heavily loaded later in the day.

Changes proposed in this pull request

  1. I cannot see an obvious way of blocking on the download, so instead I'm just checking in a loop for up to 5 seconds for the file to download

@jebw jebw requested a review from a team as a code owner January 27, 2025 17:23
Copy link
Contributor

@jebw jebw added this pull request to the merge queue Jan 28, 2025
Merged via the queue into main with commit 1944ce8 Jan 28, 2025
18 checks passed
@jebw jebw deleted the dont-use-sleep-in-specs branch January 28, 2025 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants