Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CPDNPQ-2439 Update Sinatra #2176

Merged
merged 4 commits into from
Feb 5, 2025
Merged

CPDNPQ-2439 Update Sinatra #2176

merged 4 commits into from
Feb 5, 2025

Conversation

jebw
Copy link
Contributor

@jebw jebw commented Feb 4, 2025 •
edited
Loading

Context

Ticket: 2439

Currently our flipper UI area is held back because of the Rack 2 -> 3 changes needed in other areas of the codebase

This upgrades those other components and updates the flipper UI

Changes proposed in this pull request

  1. Upgraded the flipper gems, and sinatra with them, and Rack from 2->3
  2. Fix the CSP reports controller to handle Rack 3 style request bodies
  3. Fix the API Request middleware to work with Rack3 style request bodies
  4. Avoid mocking the Rails.env var in specs
  5. Include API requests middleware in test environment, but mock out delivery to BQ - this ensures all API endpoints get tested for compatibility with the middleware

@jebw jebw requested a review from a team as a code owner February 4, 2025 12:22
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Review app deployed to https://npq-registration-review-2176-web.test.teacherservices.cloud/

@jebw jebw force-pushed the CPDNPQ-2439-update-sinatra branch from dbe51df to 64bd199 Compare February 4, 2025 14:52
@jebw
[CPDNPQ-2439] Include middleware in request stack for specs
6d9782c 
More accurately reflects how code will run in production and more
thoroughly tests middleware
@jebw jebw force-pushed the CPDNPQ-2439-update-sinatra branch from 64bd199 to 6d9782c Compare February 4, 2025 15:06
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 4, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@jebw jebw added this pull request to the merge queue Feb 5, 2025
Merged via the queue into main with commit c56745b Feb 5, 2025
18 checks passed
@jebw jebw deleted the CPDNPQ-2439-update-sinatra branch February 5, 2025 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alkesh alkesh alkesh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jebw @alkesh