Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BAU] Silence logger noise in specs #2178

Merged
merged 1 commit into from
Feb 5, 2025
Merged

[BAU] Silence logger noise in specs #2178

merged 1 commit into from
Feb 5, 2025

Conversation

jebw
Copy link
Contributor

@jebw jebw commented Feb 4, 2025

Context

Ticket: BAU

Various rake tasks are logging to stdout in specs - this isn't strictly necessary and complicates the spec output

Changes proposed in this pull request

  1. Use the regular rails logger when the tasks are running in the Rails test environment

@jebw jebw requested a review from a team as a code owner February 4, 2025 17:47
@sonarqubecloud SonarQubeCloud
Copy link

sonarqubecloud bot commented Feb 4, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
75.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Review app deployed to https://npq-registration-review-2178-web.test.teacherservices.cloud/

@jebw jebw added this pull request to the merge queue Feb 5, 2025
Merged via the queue into main with commit e5951d3 Feb 5, 2025
18 checks passed
@jebw jebw deleted the bau-silence-logging-from-specs branch February 5, 2025 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alkesh alkesh alkesh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jebw @alkesh