Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable bullet in test+review and fix N+1 #2184

Merged
merged 1 commit into from
Feb 5, 2025
Merged

Conversation

jebw
Copy link
Contributor

@jebw jebw commented Feb 5, 2025

Context

Ticket: BAU

We want to know when our pages are not optimised automated testing (ie the test environment) and manual testing during production review (ie review environment) are our best options

Changes proposed in this pull request

  1. Remove 'ignores' from bullet in test environment
  2. Enable bullet and make it hard fail in review environment
  3. Fix an N+1 which was discovered as part of this

Copy link
Contributor

github-actions bot commented Feb 5, 2025

@jebw jebw marked this pull request as ready for review February 5, 2025 14:52
@jebw jebw requested a review from a team as a code owner February 5, 2025 14:52
@jebw jebw added this pull request to the merge queue Feb 5, 2025
Merged via the queue into main with commit 499977a Feb 5, 2025
18 checks passed
@jebw jebw deleted the bau-enable-bullet-in-test branch February 5, 2025 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants