Merge pull request #908 from DFE-Digital/138562-href-bug-fix-update #3422
danielryannimble
This run and associated checks have been archived and are scheduled for deletion.
Learn more about checks retention
Annotations
12 warnings
|
lint
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
build
The following actions uses node12 which is deprecated and will be forced to run on node16: actions/checkout@v2, actions/cache@v1. For more info: https://github.blog/changelog/2023-06-13-github-actions-all-actions-will-run-on-node16-instead-of-node12-by-default/
|
|
build:
Dfe.PrepareConversions/Dfe.PrepareConversions.DocumentGeneration/Builders/BulletedListBuilder.cs#L28
Review this call, which partially matches an overload without 'params'. The partial match is 'ParagraphProperties.ParagraphProperties(IEnumerable<OpenXmlElement> childElements)'. (https://rules.sonarsource.com/csharp/RSPEC-3220)
|
|
build:
Dfe.PrepareConversions/Dfe.PrepareConversions.DocumentGeneration/Builders/BulletedListBuilder.cs#L29
Review this call, which partially matches an overload without 'params'. The partial match is 'RunProperties.RunProperties(IEnumerable<OpenXmlElement> childElements)'. (https://rules.sonarsource.com/csharp/RSPEC-3220)
|
|
build:
Dfe.PrepareConversions/Dfe.PrepareConversions.DocumentGeneration/DocumentBuilder.cs#L27
Review this call, which partially matches an overload without 'params'. The partial match is 'Document.Document(IEnumerable<OpenXmlElement> childElements)'. (https://rules.sonarsource.com/csharp/RSPEC-3220)
|
|
build:
Dfe.PrepareConversions/Dfe.PrepareConversions.DocumentGeneration/DocumentBuilder.cs#L148
Review this call, which partially matches an overload without 'params'. The partial match is 'Settings.Settings(IEnumerable<OpenXmlElement> childElements)'. (https://rules.sonarsource.com/csharp/RSPEC-3220)
|
|
build:
Dfe.PrepareConversions/Dfe.PrepareConversions.DocumentGeneration/DocumentBuilder.cs#L148
Review this call, which partially matches an overload without 'params'. The partial match is 'Compatibility.Compatibility(IEnumerable<OpenXmlElement> childElements)'. (https://rules.sonarsource.com/csharp/RSPEC-3220)
|
|
build:
Dfe.PrepareConversions/Dfe.PrepareConversions.DocumentGeneration/DocumentBuilder.cs#L201
"Find" method should be used instead of the "FirstOrDefault" extension method. (https://rules.sonarsource.com/csharp/RSPEC-6602)
|
|
build:
Dfe.PrepareConversions/Dfe.PrepareConversions.DocumentGeneration/Builders/NumberedListBuilder.cs#L28
Review this call, which partially matches an overload without 'params'. The partial match is 'ParagraphProperties.ParagraphProperties(IEnumerable<OpenXmlElement> childElements)'. (https://rules.sonarsource.com/csharp/RSPEC-3220)
|
|
build:
Dfe.PrepareConversions/Dfe.PrepareConversions.DocumentGeneration/Helpers/DocumentBuilderHelpers.cs#L24
Indexing at Count-1 should be used instead of the "Enumerable" extension method "Last" (https://rules.sonarsource.com/csharp/RSPEC-6608)
|
|
build:
Dfe.PrepareConversions/Dfe.PrepareConversions.DocumentGeneration/Helpers/HtmlToElements.cs#L72
Collection-specific "Exists" method should be used instead of the "Any" extension. (https://rules.sonarsource.com/csharp/RSPEC-6605)
|
|
build:
Dfe.PrepareConversions/Dfe.PrepareConversions.Data/Models/AcademisationApplication/AcademisationApplication.cs#L235
Remove this commented out code. (https://rules.sonarsource.com/csharp/RSPEC-125)
|