Updated Error messages

DFE-Digital · Jan 5, 2024 · e593477 · e593477
1 parent 029171e
commit e593477
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 7 deletions.
diff --git a/...areConversions/Pages/TaskList/SchoolOverview/SENNumberOfFundedResidentialPlaces.cshtml.cs b/...areConversions/Pages/TaskList/SchoolOverview/SENNumberOfFundedResidentialPlaces.cshtml.cs
@@ -34,10 +34,9 @@ public override async Task<IActionResult> OnPostAsync(int id)
       await base.OnGetAsync(id);
       if (NumberOfFundedResidentialPlaces is null)
       {
-         ModelState.AddModelError(nameof(NumberOfFundedResidentialPlaces), "You must enter the number of places funded for");
+         _errorService.AddError(nameof(NumberOfFundedResidentialPlaces), "Enter a number. No letters or special characters.");
       }
 
-
       if (ModelState.IsValid)
       {
          SetSchoolOverviewModel updatedSchoolOverview = CreateUpdateSchoolOverview(Project);
@@ -48,7 +47,6 @@ public override async Task<IActionResult> OnPostAsync(int id)
          return RedirectToPage(Links.SchoolOverviewSection.ConfirmSchoolOverview.Page, new { id });
       }
 
-      _errorService.AddErrors(ModelState.Keys, ModelState);
       return await base.OnGetAsync(id);
    }
    public static SetSchoolOverviewModel CreateUpdateSchoolOverview(ProjectViewModel projectViewModel)

diff --git a/...Dfe.PrepareConversions/Pages/TaskList/SchoolOverview/SENNumberOfPlacesFundedFor.cshtml.cs b/...Dfe.PrepareConversions/Pages/TaskList/SchoolOverview/SENNumberOfPlacesFundedFor.cshtml.cs
@@ -34,7 +34,7 @@ public override async Task<IActionResult> OnPostAsync(int id)
       await base.OnGetAsync(id);
       if (NumberOfPlacesFundedFor is null)
       {
-         ModelState.AddModelError(nameof(NumberOfPlacesFundedFor), "You must enter the number of places funded for");
+         _errorService.AddError(nameof(NumberOfPlacesFundedFor), "Enter a number. No letters or special characters.");
       }
 
 
@@ -48,7 +48,7 @@ public override async Task<IActionResult> OnPostAsync(int id)
          return RedirectToPage(Links.SchoolOverviewSection.ConfirmSchoolOverview.Page, new { id });
       }
 
-      _errorService.AddErrors(ModelState.Keys, ModelState);
+
       return await base.OnGetAsync(id);
    }
    public static SetSchoolOverviewModel CreateUpdateSchoolOverview(ProjectViewModel projectViewModel)

diff --git a/...e.PrepareConversions/Pages/TaskList/SchoolOverview/SENNumberOfResidentialPlaces.cshtml.cs b/...e.PrepareConversions/Pages/TaskList/SchoolOverview/SENNumberOfResidentialPlaces.cshtml.cs
@@ -34,7 +34,7 @@ public override async Task<IActionResult> OnPostAsync(int id)
       await base.OnGetAsync(id);
       if (NumberOfResidentialPlaces is null)
       {
-         ModelState.AddModelError(nameof(NumberOfResidentialPlaces), "You must enter the number of places funded for");
+         _errorService.AddError(nameof(NumberOfResidentialPlaces), "Enter a number. No letters or special characters.");
       }
 
 
@@ -48,7 +48,6 @@ public override async Task<IActionResult> OnPostAsync(int id)
          return RedirectToPage(Links.SchoolOverviewSection.ConfirmSchoolOverview.Page, new { id });
       }
 
-      _errorService.AddErrors(ModelState.Keys, ModelState);
       return await base.OnGetAsync(id);
    }
    public static SetSchoolOverviewModel CreateUpdateSchoolOverview(ProjectViewModel projectViewModel)