Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cypress refactor #1058

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Cypress refactor #1058

wants to merge 1 commit into from

Conversation

FahadDarw
Copy link
Collaborator

@FahadDarw FahadDarw commented May 17, 2024

Title: Enhanced Cypress Test Suite for "Form a MAT" and "Voluntary Conversion" Projects in School Application Form

Description:
Our Cypress test suite has been significantly enhanced to incorporate additional checks and functionalities for the "Form a MAT" and "Voluntary Conversion" projects. The updates include:

  1. Implementation of filtering and selection logic based on "Fahads Cypress Trust" for project identification for both Conversion and Form A MAT projects.
  2. Validation of page titles and routes.
  3. Interaction with the school application form and validation of its table of contents for both Conversion and Form A MAT projects.
  4. Integration of methods to verify URLs containing "school-application-form" for Voluntary Conversion and "schools-in-this-mat" for Form a MAT.
  5. Addition of specialised methods tailored for interacting with "Form a MAT" projects.
  6. Inclusion of assertions to ensure specific elements display expected text, such as "Overview1_value" (Application to join: ) and "ApplicationReference_value" (Application reference:).

Assignees:

  • Fahad Darwish

Tags:

  • Cypress
  • End-to-End Testing
  • "Form a MAT"
  • "Voluntary Conversion"
  • Quality Assurance

Kindly review the updates and proceed with merging the PR if everything aligns with expectations. Your cooperation is highly appreciated!

Copy link

@mikestock-nimble mikestock-nimble left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can't confirm the logic for the test, but structurally, apart from the one observation, it looks ok to me

@@ -17,12 +17,12 @@
<div class="govuk-grid-row">
<div class="govuk-grid-column-two-thirds">
<h2 class="govuk-heading-l govuk-!-margin-bottom govuk-!-font-size-36">School application form</h2>
<nav class="gem-c-contents-list" aria-label="Pages in this guide" role="navigation" data-module="gem-track-click">
<nav class="gem-c-contents-list" aria-label="Pages in this guide" role="navigation" data-module="gem-track-click" data-cy="content-Table">
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should probably have some consistency in the tags i.e. all lowercase and using either - or _. I'm not fussy which, but will make it easier to maintain

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

will do :)

it('Should filter and select the project, then verify details of Voluntary', () => {

// Step 1: Filter search
applicationFormTaskList.filterSearch('Fahads Cypress Trust');
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe just "Cypress Trust"?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need it to be Fahads Cypress Trust as Elijah has already created those cases for me. but next time I can try and change the name

@FahadDarw FahadDarw requested a review from cshnimble July 9, 2024 12:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants