Fix App Insights JS #1226
Merged
Fix App Insights JS #1226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
DrizzlyOwl
commented
Nov 28, 2024
•
DrizzlyOwl
commented
- Making it a shared partial keeps the _layout.cshtml cleaner
- Extract App Insights connection string into Options
- Modifies the Dockerfile to ensure that application-insights.min.js is compiled at build-time. This fixes the issue wherein the JS was not being loaded on the frontend
DrizzlyOwl
requested review from
dneed-nimble,
paullocknimble,
danielryannimble,
dangood84,
nwarms,
elielijah321,
FahadDarw and
mshakirdfe
as code owners
DrizzlyOwl
force-pushed
the
feature/app-insights-frontend-sdk
branch
from
1ce3549 to
0e89d8e
Compare
DrizzlyOwl
force-pushed
the
feature/app-insights-frontend-sdk
branch
from
0e89d8e to
12a9ed2
Compare
DrizzlyOwl
force-pushed
the
feature/app-insights-frontend-sdk
branch
from
12a9ed2 to
19b1803
Compare
* Making it a shared partial keeps the _layout.cshtml cleaner * Adds missing configuration for click tracking and user identification * Extract App Insights connection string into Options
DrizzlyOwl
force-pushed
the
feature/app-insights-frontend-sdk
branch
from
320d60c to
59df364
Compare
|
mshakirdfe
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.