Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Keyword searching #4453

Draft
wants to merge 67 commits into
base: main
Choose a base branch
from
Draft

WIP: Keyword searching #4453

wants to merge 67 commits into from

Conversation

dcyoung-dev
Copy link
Contributor

Context

Changes proposed in this pull request

Guidance to review

Things to check

  • This code does not rely on migrations in the same Pull Request
  • If this code includes a migration adding or changing columns, it also backfills existing records for consistency
  • If this code adds a column to the DB, decide whether it needs to be in analytics yml file or analytics blocklist
  • API release notes have been updated if necessary
  • Required environment variables have been updated added to the Azure KeyVault
  • Inform data insights team due to database changes
  • Make sure all information from the Trello card is in here
  • Rebased main
  • Cleaned commit history
  • Tested by running locally
  • Attach PR to Trello card

@dcyoung-dev dcyoung-dev marked this pull request as ready for review August 15, 2024 13:50
@dcyoung-dev dcyoung-dev marked this pull request as draft August 15, 2024 13:51
@dcyoung-dev
Copy link
Contributor Author

Find Prototype app
https://find-review-4453.test.teacherservices.cloud/

@dcyoung-dev dcyoung-dev force-pushed the dy-search-spike branch 4 times, most recently from 37bd4fe to f527f3e Compare August 23, 2024 14:11
@dcyoung-dev dcyoung-dev force-pushed the dy-search-spike branch 2 times, most recently from dc03c2b to 67dd52b Compare September 6, 2024 14:28
@dcyoung-dev dcyoung-dev marked this pull request as ready for review September 6, 2024 14:44
@dcyoung-dev dcyoung-dev marked this pull request as draft September 6, 2024 15:02
@avinhurry avinhurry closed this Sep 10, 2024
@avinhurry avinhurry reopened this Sep 10, 2024
@github-actions github-actions bot temporarily deployed to review_aks-4453 September 10, 2024 09:03 Destroyed
@Nitemaeric Nitemaeric closed this Nov 6, 2024
@Nitemaeric Nitemaeric reopened this Nov 6, 2024
@Nitemaeric Nitemaeric changed the base branch from main to dd/search-spike-backup November 6, 2024 10:40
@Nitemaeric Nitemaeric changed the base branch from dd/search-spike-backup to main November 6, 2024 10:44
kelliedesigner and others added 24 commits December 16, 2024 16:14
@kelliedesigner @Nitemaeric
Update secondary page title
9b21efb
@kelliedesigner @Nitemaeric
!wip primary sepcialisms page
9b37a8e
@kelliedesigner @Nitemaeric
Add primary specialisms page
95de27e
@kelliedesigner @Nitemaeric
Add salaried GiT link
38b5727
@kelliedesigner @Nitemaeric
Update primary, secondary, and degree filters
29dbad1
@kelliedesigner @Nitemaeric
update label all primary/secondary courses
e112d33
@kelliedesigner @Nitemaeric
Fix apply button at bottom
f8c22de
@kelliedesigner @Nitemaeric
Update content on start date filter
05fd32a
@kelliedesigner @Nitemaeric
Update SEND links
6123ef5
@kelliedesigner @Nitemaeric
Update primary secondary primary links
d8f7341
@kelliedesigner @Nitemaeric
Fix FE link
f11deed
@kelliedesigner @Nitemaeric
Fix primary and secondary buttons to search only for their age group
ecc0f5f
@kelliedesigner @Nitemaeric
Add FE filter
7e9c515
@kelliedesigner @Nitemaeric
Fix spacing
d4244d3
@kelliedesigner @Nitemaeric
Add GiT links to accordion on home
13459df
@kelliedesigner @Nitemaeric
Fix degre require filter on advanced search
f11fc84
@kelliedesigner @Nitemaeric
Fix degree required filter on advanced search
85a1197
@kelliedesigner @Nitemaeric
Fix homepage links
dd4329b
@Nitemaeric
Update primary_courses_path destination
947d13c
@kelliedesigner @Nitemaeric
Update qual filter label
1584564
@kelliedesigner @Nitemaeric
Update age group filter content
5fd4931
@kelliedesigner @Nitemaeric
Update fee and salary content
5eca209
@kelliedesigner @Nitemaeric
Update qualification label
a6e8e40
@kelliedesigner @Nitemaeric
Update school placements content
298ae2f
@github-actions github-actions bot temporarily deployed to review-4453 December 16, 2024 16:19 Destroyed
@github-actions github-actions bot temporarily deployed to review-4453 December 20, 2024 12:22 Destroyed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@kelliedesigner kelliedesigner

Labels
deploy A Review App will be created for PRs with this label spike
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dcyoung-dev @Nitemaeric @kelliedesigner @avinhurry