Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove canonical-rails gem and handroll our own #4713

Merged
merged 8 commits into from
Nov 27, 2024

Conversation

gms-gs
Copy link
Contributor

@gms-gs gms-gs commented Nov 26, 2024

Context

When upgrading to Rails 8 the canonical-rails gem had issues with compatibility, after looking into the gem it looked pretty simple enough to handroll ourselves and also remove code.

Ticket: https://trello.com/c/kPLDsLbC/269-remove-gem-canonical-rails-and-handroll-our-own-implementation

Changes proposed in this pull request

Instead of using <%= canonical_tag %> we handroll our own implementation for these tags

Guidance to review

Review app tags handrolled:
Screenshot 2024-11-26 at 13 09 58

Prod app tags using the gem:
Screenshot 2024-11-26 at 12 50 08

@gms-gs gms-gs self-assigned this Nov 26, 2024
@gms-gs gms-gs added the deploy A Review App will be created for PRs with this label label Nov 26, 2024
@gms-gs gms-gs marked this pull request as ready for review November 26, 2024 12:55
@gms-gs gms-gs requested a review from a team as a code owner November 26, 2024 12:55
@gms-gs
Copy link
Contributor Author

gms-gs commented Nov 26, 2024

@gms-gs gms-gs merged commit 118de9e into main Nov 27, 2024
19 checks passed
@gms-gs gms-gs deleted the gs/feature/remove-canonical-rails-gem branch November 27, 2024 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy A Review App will be created for PRs with this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants