Bump to rails version 8.0.0 #4714
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gms-gs
force-pushed
the
bump-rails-v-8.0.0
branch
from
6dde0e7 to
1973f42
Compare
gms-gs
commented
Nov 26, 2024
gms-gs
changed the base branch from
main
to
gs/feature/remove-canonical-rails-gem
gms-gs
force-pushed
the
bump-rails-v-8.0.0
branch
3 times, most recently
from
f0e7385 to
439dd11
Compare
Base automatically changed from
gs/feature/remove-canonical-rails-gem
to
main
November 27, 2024 12:07
gms-gs
force-pushed
the
bump-rails-v-8.0.0
branch
2 times, most recently
from
238ec68 to
ff2eb58
Compare
gms-gs
force-pushed
the
bump-rails-v-8.0.0
branch
2 times, most recently
from
fcfa052 to
f24e479
Compare
Nitemaeric
reviewed
Dec 2, 2024
gms-gs
force-pushed
the
bump-rails-v-8.0.0
branch
3 times, most recently
from
3a033fa to
d84bdf4
Compare
gms-gs
force-pushed
the
bump-rails-v-8.0.0
branch
9 times, most recently
from
14d9b20 to
b34e6fb
Compare
inulty-dfe
reviewed
Dec 2, 2024
gms-gs
force-pushed
the
bump-rails-v-8.0.0
branch
2 times, most recently
from
209f100 to
98ddd5a
Compare
We can't pass Structs when updating records in rails 8 any more, we need to pass nil not Struct(day: 1, month: nil, year: nil) when creating or updating records.
gms-gs
force-pushed
the
bump-rails-v-8.0.0
branch
3 times, most recently
from
06dc371 to
c2b0ca1
Compare
Rails 8 added a new attribute that AccreditingProviderEnrichment now needs to ignore context_for_validation.
gms-gs
force-pushed
the
bump-rails-v-8.0.0
branch
from
c2b0ca1 to
2a29f36
Compare
Nitemaeric
approved these changes
Dec 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Ticket: https://trello.com/c/uEmppsew/262-upgrade-to-rails-8
As part of keeping the application up to date we decided to upgrade to Rails 8.0.0
Changes proposed in this pull request
Ran
rails app:updatewhich created/edited a lot of files.Guidance to review
Play through the review app and see if things are working as expected, however we can hopefully rely on all tests passing as a good indicator of a successful upgrade.