Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rubocop from 1.68.0 to 1.69.0 #4720

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Nov 28, 2024

Bumps rubocop from 1.68.0 to 1.69.0.

Release notes

Sourced from rubocop's releases.

RuboCop 1.69

New features

Bug fixes

  • #13455: Fix a false positive for Layout/EmptyLineAfterGuardClause when using a guard clause outside oneliner block. (@​koic)
  • #13412: Fix a false positive for Style/RedundantLineContinuation when there is a line continuation at the end of Ruby code followed by __END__ data. (@​koic)
  • #13476: Allow to write generics type of RBS::Inline annotation after subclass definition in Style/CommentedKeyword. ([@​dak2][])
  • #13441: Fix an incorrect autocorrect for Style/IfWithSemicolon when using return with value in if with a semicolon is used. (@​koic)
  • #13448: Fix an incorrect autocorrect for Style/IfWithSemicolon when the then body contains an arithmetic operator method call with an argument. (@​koic)
  • #13199: Make Style/RedundantCondition skip autocorrection when a branch has a comment. (@​koic)
  • #13411: Fix Style/BitwisePredicate when having regular method. ([@​d4be4st][])
  • #13432: Fix false positive for Lint/FloatComparison against nil. ([@​lovro-bikic][])
  • #13461: Fix false positives for Lint/InterpolationCheck when using invalid syntax in interpolation. (@​koic)
  • #13402: Fix a false positive for Lint/SafeNavigationConsistency when using unsafe navigation with both && and ||. (@​koic)
  • #13434: Fix a false positive for Naming/MemoizedInstanceVariableName for assignment methods`. ([@​earlopain][])
  • #13415: Fix false positives for Naming/MemoizedInstanceVariableName when using initialize_clone, initialize_copy, or initialize_dup. (@​koic)
  • #13421: Fix false positives for Style/SafeNavigation when using a method chain that exceeds the MaxChainLength value and includes safe navigation operator. (@​koic)
  • #13433: Fix autocorrection for Style/AccessModifierDeclarations for multiple inline symbols. ([@​dvandersluis][])
  • #13430: Fix EmptyLinesAroundMethodBody for methods with arguments spanning multiple lines. ([@​aduth][])
  • #13438: Fix incorrect correction in Lint/Void if an operator is called in a void context using a dot. ([@​dvandersluis][])
  • #13419: Fix Lint/DeprecatedOpenSSLConstant false positive when the argument is a safe navigation method call. ([@​dvandersluis][])
  • #13404: Fix Style/AccessModifierDeclarations to register (as positive or negative, depending on AllowModifiersOnSymbols value) access modifiers with multiple symbols. ([@​dvandersluis][])
  • #13436: Fix incorrect offense and autocorrect for Lint/RedundantSplatExpansion when percent literal array is used in a safe navigation method call. ([@​lovro-bikic][])
  • #13442: Fix an incorrect autocorrect for Style/NestedTernaryOperator when ternary operators are nested and the inner condition is parenthesized. (@​koic)
  • #13444: Fix an incorrect autocorrect for Style/OneLineConditional when the else branch of a ternary operator has multiple expressions. (@​koic)
  • #13483: Fix an incorrect autocorrect for Style/RedundantRegexpArgument when using escaped double quote character. (@​koic)
  • #13497: Fix infinite loop error for Style/IfWithSemicolon when using nested if/;/end in if body. (@​koic)
  • #13477: Update Layout/LeadingCommentSpace to accept multiline shebangs at the top of the file. ([@​dvandersluis][])
  • #13453: Update Style/AccessModifierDeclarations to handle attr_* methods with multiple parameters. ([@​dvandersluis][])
  • #12597: Update Style/SingleLineDoEndBlock to not register an offense if it will introduce a conflicting Layout/RedundantLineBreak offense. ([@​dvandersluis][])

Changes

... (truncated)

Changelog

Sourced from rubocop's changelog.

1.69.0 (2024-11-26)

New features

Bug fixes

  • #13455: Fix a false positive for Layout/EmptyLineAfterGuardClause when using a guard clause outside oneliner block. ([@​koic][])
  • #13412: Fix a false positive for Style/RedundantLineContinuation when there is a line continuation at the end of Ruby code followed by __END__ data. ([@​koic][])
  • #13476: Allow to write generics type of RBS::Inline annotation after subclass definition in Style/CommentedKeyword. ([@​dak2][])
  • #13441: Fix an incorrect autocorrect for Style/IfWithSemicolon when using return with value in if with a semicolon is used. ([@​koic][])
  • #13448: Fix an incorrect autocorrect for Style/IfWithSemicolon when the then body contains an arithmetic operator method call with an argument. ([@​koic][])
  • #13199: Make Style/RedundantCondition skip autocorrection when a branch has a comment. ([@​koic][])
  • #13411: Fix Style/BitwisePredicate when having regular method. ([@​d4be4st][])
  • #13432: Fix false positive for Lint/FloatComparison against nil. ([@​lovro-bikic][])
  • #13461: Fix false positives for Lint/InterpolationCheck when using invalid syntax in interpolation. ([@​koic][])
  • #13402: Fix a false positive for Lint/SafeNavigationConsistency when using unsafe navigation with both && and ||. ([@​koic][])
  • #13434: Fix a false positive for Naming/MemoizedInstanceVariableName for assignment methods`. ([@​earlopain][])
  • #13415: Fix false positives for Naming/MemoizedInstanceVariableName when using initialize_clone, initialize_copy, or initialize_dup. ([@​koic][])
  • #13421: Fix false positives for Style/SafeNavigation when using a method chain that exceeds the MaxChainLength value and includes safe navigation operator. ([@​koic][])
  • #13433: Fix autocorrection for Style/AccessModifierDeclarations for multiple inline symbols. ([@​dvandersluis][])
  • #13430: Fix EmptyLinesAroundMethodBody for methods with arguments spanning multiple lines. ([@​aduth][])
  • #13438: Fix incorrect correction in Lint/Void if an operator is called in a void context using a dot. ([@​dvandersluis][])
  • #13419: Fix Lint/DeprecatedOpenSSLConstant false positive when the argument is a safe navigation method call. ([@​dvandersluis][])
  • #13404: Fix Style/AccessModifierDeclarations to register (as positive or negative, depending on AllowModifiersOnSymbols value) access modifiers with multiple symbols. ([@​dvandersluis][])
  • #13436: Fix incorrect offense and autocorrect for Lint/RedundantSplatExpansion when percent literal array is used in a safe navigation method call. ([@​lovro-bikic][])
  • #13442: Fix an incorrect autocorrect for Style/NestedTernaryOperator when ternary operators are nested and the inner condition is parenthesized. ([@​koic][])
  • #13444: Fix an incorrect autocorrect for Style/OneLineConditional when the else branch of a ternary operator has multiple expressions. ([@​koic][])
  • #13483: Fix an incorrect autocorrect for Style/RedundantRegexpArgument when using escaped double quote character. ([@​koic][])
  • #13497: Fix infinite loop error for Style/IfWithSemicolon when using nested if/;/end in if body. ([@​koic][])
  • #13477: Update Layout/LeadingCommentSpace to accept multiline shebangs at the top of the file. ([@​dvandersluis][])
  • #13453: Update Style/AccessModifierDeclarations to handle attr_* methods with multiple parameters. ([@​dvandersluis][])
  • #12597: Update Style/SingleLineDoEndBlock to not register an offense if it will introduce a conflicting Layout/RedundantLineBreak offense. ([@​dvandersluis][])

Changes

Commits
  • 9a49a33 Cut 1.69
  • 96833cd Update Changelog
  • 32c8dd5 Merge pull request #13498 from dvandersluis/useless-include-util
  • 2904985 Remove unnecessary include Util
  • 77f3e6f Create Style/FileTouch cop
  • 8ac8947 Fix infinite loop error for Style/IfWithSemicolon
  • beb22bc Update Style/SingleArgumentDig to not register offenses on chained dig ca...
  • c8cdb3d [Fix #13486] Add new Style/DigChain cop
  • efc3fd8 [Fix #13490] Add new Style/FileNull cop
  • 8717f11 Remove unnecessary include IgnoredNode
  • Additional commits viewable in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
  • @dependabot show <dependency name> ignore conditions will show all of the ignore conditions of the specified dependency
  • @dependabot ignore this major version will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this minor version will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)
  • @dependabot ignore this dependency will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)

Bumps [rubocop](https://github.com/rubocop/rubocop) from 1.68.0 to 1.69.0.
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v1.68.0...v1.69.0)

---
updated-dependencies:
- dependency-name: rubocop
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
@dependabot dependabot bot added the dependencies Pull requests that update a dependency file label Nov 28, 2024
@dependabot dependabot bot requested a review from a team as a code owner November 28, 2024 03:42
@dependabot dependabot bot added the ruby Pull requests that update Ruby code label Nov 28, 2024
@Nitemaeric Nitemaeric added the deploy A Review App will be created for PRs with this label label Nov 28, 2024
@github-actions github-actions bot temporarily deployed to review-4720 November 28, 2024 09:58 Destroyed
Copy link
Contributor Author

dependabot bot commented on behalf of github Dec 4, 2024

A newer version of rubocop exists, but since this PR has been edited by someone other than Dependabot I haven't updated it. You'll get a PR for the updated version as normal once this PR is merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file deploy A Review App will be created for PRs with this label ruby Pull requests that update Ruby code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants