Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace terrafile #4729

Merged
merged 1 commit into from
Dec 3, 2024
Merged

Replace terrafile #4729

merged 1 commit into from
Dec 3, 2024

Conversation

neillturner
Copy link

@neillturner neillturner commented Dec 2, 2024

Context

Replace terrafile as it's not maintained anymore. Using simple git instead.

Changes proposed in this pull request

  • Update makefile to remove references to terrafile
  • Update makefile to add new vendor-modules target with git command to correct location for terraform code
  • In global_config directory add correct value for TERRAFORM_MODULES_TAG in config files
  • In terraform/aks/workspace_variables directory remove terrafile files
  • Update .gitignore remove bin/terrafile
  • in custom domains change terraform code to reference vendor/modules directory

Guidance to review

i tested for each environment and to see terraform correctly get the module code
make dv_review deploy-plan PR_NUMBER=1234 USE_DB_SETUP_COMMAND=false CLUSTER=cluster1
make production deploy-plan CONFIRM_PRODUCTION=yes
make qa deploy-plan
make review deploy-plan PR_NUMBER=1234 USE_DB_SETUP_COMMAND=false
make sandbox deploy-plan
make staging deploy-plan

make find domains-infra-plan
make publish domains-infra-plan

make publish qa domains-plan
make publish production domains-plan

make publish sandbox domains-plan
make publish staging domains-plan

Link to Trello card

Replace terrafile

Checklist

  • Attach to Trello card
  • Rebased main
  • Cleaned commit history
  • Tested by running locally

@neillturner neillturner requested a review from a team as a code owner December 2, 2024 13:02
@neillturner
Copy link
Author

Replace terrafile

@neillturner
Copy link
Author

Replace terrafile

1 similar comment
@neillturner
Copy link
Author

Replace terrafile

Copy link
Member

@saliceti saliceti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@neillturner neillturner merged commit 7a72c8c into main Dec 3, 2024
38 checks passed
@neillturner neillturner deleted the replace-terrafile branch December 3, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants