Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add HTTP request context to sentry #4766

Merged
merged 2 commits into from
Dec 13, 2024
Merged

Conversation

Nitemaeric
Copy link
Contributor

@Nitemaeric Nitemaeric commented Dec 13, 2024

Context

We have a strange Sentry error that pops up frequently. We want to track down the cause of this issue, but we don't have enough information. It seems that the query parameters are causing the issue. Let's add them to our Sentry context.

Changes proposed in this pull request

  • Add request contexts to Sentry.

Guidance to review

@Nitemaeric Nitemaeric added the deploy A Review App will be created for PRs with this label label Dec 13, 2024
@Nitemaeric Nitemaeric force-pushed the dd/add-context-to-sentry branch from 5ba3f20 to cccea83 Compare December 13, 2024 15:28
This add profiling to our Sentry configuration.
@Nitemaeric Nitemaeric force-pushed the dd/add-context-to-sentry branch from cccea83 to 0ae6a32 Compare December 13, 2024 16:05
@Nitemaeric Nitemaeric self-assigned this Dec 13, 2024
@Nitemaeric Nitemaeric marked this pull request as ready for review December 13, 2024 16:16
@Nitemaeric Nitemaeric requested a review from a team as a code owner December 13, 2024 16:16
@Nitemaeric Nitemaeric changed the title Dd/add context to sentry Add HTTP request context to sentry Dec 13, 2024
@@ -40,6 +40,7 @@ gem 'jsonb_accessor'
gem 'sentry-rails'
gem 'sentry-ruby'
gem 'sentry-sidekiq'
gem 'stackprof'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we add only for development?

Copy link
Contributor

@tomas-stefano tomas-stefano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, just one minor question. Can you also put the benefits of adding the gem, the example outputs and etc?

@Nitemaeric Nitemaeric merged commit 23d8cd5 into main Dec 13, 2024
19 checks passed
@Nitemaeric Nitemaeric deleted the dd/add-context-to-sentry branch December 13, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy A Review App will be created for PRs with this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants