Foundation for the pre filter work add Funding filter #4774
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Always good to have more scenarios tested!
On the live (v1) results page there are no fee and apprenticeship filters, only salary and these is treated as a string "salary". We want to add a collection now, so adding this compatibility to make work
tomas-stefano
added
the
deploy
tomas-stefano
changed the title
tomas-stefano
commented
Dec 16, 2024
| @@ -21,8 +21,10 @@ def search_courses_params | |||
| :send_courses, | |||
| :applications_open, | |||
| :further_education, | |||
| :funding, | |||
There was a problem hiding this comment.
This one sounds duplicate but not! It is to be backwards compatible with the currently production page. See commit message and PR description for more info.
Nitemaeric
approved these changes
Dec 16, 2024
tomas-stefano
deleted the
td/289-foundation-for-the-pre-filter-work-add-fee-or-salary-filter
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR adds the funding type filter on the v2 results page
Caveats
For backwards compatibility the funding is string on the live site (v1 results page). This PR adds an array but also accept the funding as string for compatibility.
Changes proposed in this pull request
Guidance to review