Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move TrainingProviders to Providers module #4776

Merged
merged 1 commit into from
Dec 17, 2024

Conversation

inulty-dfe
Copy link
Contributor

@inulty-dfe inulty-dfe commented Dec 16, 2024

Context

TrainingProviders controller currently sits outside the Providers module despite it looking for all intents and purposes as depending on the provider.

In order to make sensible changes further down the line WRT to how Accredited providers view Training providers and vice versa, I propose we move the TrainingProviders module into the Providers module for consistency.

Changes proposed in this pull request

Move modules in a refactoring without changing any behaviour

module Publish
  module TrainingProvidersController


### To

module Publish
  module Providers
    module TrainingProvidersController

The use of this controller is for the AccreditedProvider to be able to see the courses of their training providers

training-providers training-providers/A01/courses
image image

Guidance to review

@inulty-dfe inulty-dfe force-pushed the im/move-training-providers-to-providers-module branch 2 times, most recently from 8f73c6d to e610177 Compare December 16, 2024 16:35
@inulty-dfe inulty-dfe force-pushed the im/move-training-providers-to-providers-module branch from e610177 to de6f218 Compare December 16, 2024 16:51
@inulty-dfe inulty-dfe marked this pull request as ready for review December 16, 2024 17:03
@inulty-dfe inulty-dfe requested a review from a team as a code owner December 16, 2024 17:03
@inulty-dfe inulty-dfe added the deploy A Review App will be created for PRs with this label label Dec 16, 2024
@inulty-dfe
Copy link
Contributor Author

@inulty-dfe inulty-dfe added deploy A Review App will be created for PRs with this label and removed deploy A Review App will be created for PRs with this label labels Dec 17, 2024
@inulty-dfe inulty-dfe merged commit 2bceab5 into main Dec 17, 2024
57 checks passed
@inulty-dfe inulty-dfe deleted the im/move-training-providers-to-providers-module branch December 17, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
deploy A Review App will be created for PRs with this label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants