Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove domains vendor module #1260

Merged
merged 1 commit into from
Dec 2, 2024
Merged

Remove domains vendor module #1260

merged 1 commit into from
Dec 2, 2024

Conversation

saliceti
Copy link
Member

@saliceti saliceti commented Dec 2, 2024

Context

It should be downloaded using terrafile, not committed as a submodule

Changes proposed in this pull request

Remove environment_domains vendor module

Guidance to review

  • Check list of files
  • make aks-preprod domains-plan

Checklist

  • Attach to Trello card
  • Rebased main
  • Cleaned commit history
  • Tested by running locally

It should be downloaded using terrafile, not committed as a submodule
@saliceti saliceti requested a review from a team as a code owner December 2, 2024 13:30
@saliceti saliceti requested review from RMcVelia and removed request for a team December 2, 2024 13:30
@saliceti
Copy link
Member Author

saliceti commented Dec 2, 2024

@saliceti saliceti added the devops label Dec 2, 2024
@saliceti saliceti merged commit eb163ea into main Dec 2, 2024
16 checks passed
@saliceti saliceti deleted the remove-domains-vendor branch December 2, 2024 13:45
Copy link

github-actions bot commented Dec 2, 2024

Review app refer serious misconduct deployed to https://refer-serious-misconduct-1260.test.teacherservices.cloud was deleted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants