Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace terrafile #1269

Merged
merged 1 commit into from
Dec 5, 2024
Merged

Replace terrafile #1269

merged 1 commit into from
Dec 5, 2024

Conversation

neillturner
Copy link
Contributor

Context

Replace terrafile as it's not maintained anymore. Using simple git instead.

Changes proposed in this pull request

  • Update makefile to remove references to terrafile
  • Update makefile to add new vendor-modules target with git command to correct location for terraform code
  • In global_config directory add correct value for TERRAFORM_MODULES_TAG in config files
  • in terraform/application/config remove terrafile files
  • In terraform/domains directory remove terrafile files
  • Update .gitignore remove bin/terrafile

Guidance to review

i tested for each environment and to see terraform correctly get the module code
make aks-test aks-terraform-plan
make aks-review aks-terraform-plan PR_NUMBER=1234
make aks-preprod aks-terraform-plan
make aks-production aks-terraform-plan

make domains-infra-plan
make aks-test domains-plan
make aks-preprod domains-plan
make aks-production domains-plan

Link to Trello card

Replace terrafile

Checklist

  • Attach to Trello card
  • Rebased main
  • Cleaned commit history
  • Tested by running locally

@neillturner neillturner requested a review from a team as a code owner December 5, 2024 13:07
@neillturner neillturner requested review from saliceti and removed request for a team December 5, 2024 13:07
@neillturner neillturner merged commit 154f4d6 into main Dec 5, 2024
10 checks passed
@neillturner neillturner deleted the replace-terrafile branch December 5, 2024 15:46
Copy link

github-actions bot commented Dec 5, 2024

Review app refer serious misconduct deployed to https://refer-serious-misconduct-1269.test.teacherservices.cloud was deleted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants