Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable gcp in test #1283

Merged
merged 1 commit into from
Dec 17, 2024
Merged

Enable gcp in test #1283

merged 1 commit into from
Dec 17, 2024

Conversation

neillturner
Copy link
Contributor

@neillturner neillturner commented Dec 17, 2024

Context

Enable gcp wifi in test environment

Changes proposed in this pull request

Enable gcp wifi in test environment

Guidance to review

review parameter setting correct

Link to Trello card

RSM: migrate to GCP WIF

Checklist

  • Attach to Trello card
  • Rebased main
  • Cleaned commit history
  • Tested by running locally

@neillturner neillturner requested a review from a team as a code owner December 17, 2024 10:44
@neillturner neillturner requested review from RMcVelia and vipin-dfe and removed request for a team December 17, 2024 10:44
Copy link

github-actions bot commented Dec 17, 2024

Review app refer serious misconduct deployed to https://refer-serious-misconduct-1283.test.teacherservices.cloud was deleted

Copy link
Contributor

@vipin-dfe vipin-dfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@neillturner neillturner removed the request for review from RMcVelia December 17, 2024 11:11
Copy link
Contributor

@vipin-dfe vipin-dfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@neillturner neillturner merged commit 6b9925b into main Dec 17, 2024
18 checks passed
@neillturner neillturner deleted the gcp-test branch December 17, 2024 11:13
@neillturner
Copy link
Contributor Author

RSM: migrate to GCP WIF

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants