Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add file size to validation tracking #927

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Add file size to validation tracking #927

merged 1 commit into from
Dec 5, 2023

Conversation

asmega
Copy link
Contributor

@asmega asmega commented Dec 1, 2023 •
edited
Loading

Context

  • We want to track file sizes when users upload files over the max size limit to determine what the threshold should be

Changes

  • When validation errors kicks in that user has uploaded file size too big, add this to the current validation tracking mechanism to also include the file size of the uploaded file

Screenshots

upload-over-max-size

@asmega asmega added the deploy Triggers the Docker build and push job label Dec 1, 2023
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 1, 2023

Review app deployed to https://s165d01-rsm-review-pr-927-app.azurewebsites.net

@asmega asmega force-pushed the validation-tracking branch from 5e2d6db to e70b70b Compare December 1, 2023 10:52
@asmega asmega changed the title add file size to validation tracking Add file size to validation tracking Dec 4, 2023
@asmega asmega marked this pull request as ready for review December 4, 2023 11:39
richardpattinson
richardpattinson approved these changes Dec 4, 2023
View reviewed changes
Copy link
Contributor

@richardpattinson richardpattinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Nice work

@asmega asmega merged commit 7dedfd2 into main Dec 5, 2023
12 checks passed
@asmega asmega deleted the validation-tracking branch December 5, 2023 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardpattinson richardpattinson richardpattinson approved these changes

Assignees
No one assigned
Labels
deploy Triggers the Docker build and push job
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asmega @richardpattinson