Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EPIC] Withdrawals v3 #4832

Draft
wants to merge 7 commits into
base: main
Choose a base branch
from
Draft

[EPIC] Withdrawals v3 #4832

wants to merge 7 commits into from

Conversation

d-a-v-e
Copy link
Contributor

@d-a-v-e d-a-v-e commented Nov 25, 2024

Context

Changes proposed in this pull request

Guidance to review

Important business

  • Does this PR introduce any PII fields that need to be overwritten or deleted in db/scripts/sanitise.sql?
  • Does this PR change the database schema? If so, have you updated the config/analytics.yml file and considered whether you need to send 'import_entity' events?
  • Do we need to send any updates to DQT as part of the work in this PR?
  • Does this PR need an ADR?

NB: Please notify the #twd_data_insights team and ask for a review if new fields are being added to analytics.yml

Copy link

codecov bot commented Nov 25, 2024

Codecov Report

Attention: Patch coverage is 98.05825% with 2 lines in your changes missing coverage. Please review.

Project coverage is 96.07%. Comparing base (d661e02) to head (69c3865).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
...ainees/withdrawal/extra_informations_controller.rb 0.00% 1 Missing ⚠️
app/forms/withdrawal/reason_form.rb 95.23% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4832      +/-   ##
==========================================
+ Coverage   96.06%   96.07%   +0.01%     
==========================================
  Files         742      749       +7     
  Lines       16040    16122      +82     
==========================================
+ Hits        15409    15490      +81     
- Misses        631      632       +1     
Flag Coverage Δ
unittests 96.07% <98.05%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@d-a-v-e d-a-v-e changed the title [7827] - Encapsulate Withdrawal (#4826) Withdrawals v3 Nov 25, 2024
@d-a-v-e d-a-v-e force-pushed the withdrawals-flow-v3 branch from 6bc2f75 to 191dde6 Compare November 26, 2024 12:40
@d-a-v-e d-a-v-e changed the title Withdrawals v3 [EPIC] Withdrawals v3 Nov 26, 2024
@d-a-v-e d-a-v-e added the DO NOT MERGE Things could break if this gets merged label Nov 26, 2024
@d-a-v-e d-a-v-e force-pushed the withdrawals-flow-v3 branch from 432b06c to c0a16bf Compare December 4, 2024 10:45
@kennyevil kennyevil force-pushed the withdrawals-flow-v3 branch 4 times, most recently from 9114eca to d4ee0b3 Compare December 9, 2024 12:41
@kennyevil kennyevil force-pushed the withdrawals-flow-v3 branch from d4ee0b3 to 000cce2 Compare December 9, 2024 12:58
kennyevil and others added 4 commits December 12, 2024 15:32
* add withdrawl trigger page

* update error message

* remove comments

* update rubocop

* disable safe navigation chain length cop

* add specs for trigger form
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE Things could break if this gets merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants