Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7942] Add empty CSV template for bulk trainee upload #4906

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

stevehook
Copy link
Contributor

Context

Add the link for the empty bulk trainee upload CSV template.

Changes proposed in this pull request

  • Store the sample file given in the requirements
  • Serve this file from a new controller with attachment disposition
  • Extend feature spec to cover the new route

Guidance to review

Important business

  • Does this PR introduce any PII fields that need to be overwritten or deleted in db/scripts/sanitise.sql?
  • Does this PR change the database schema? If so, have you updated the config/analytics.yml file and considered whether you need to send 'import_entity' events?
  • Do we need to send any updates to DQT as part of the work in this PR?
  • Does this PR need an ADR?

NB: Please notify the #twd_data_insights team and ask for a review if new fields are being added to analytics.yml

Copy link

codecov bot commented Dec 19, 2024

Codecov Report

Attention: Patch coverage is 66.66667% with 3 lines in your changes missing coverage. Please review.

Project coverage is 96.09%. Comparing base (943e89f) to head (fa440b9).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
..._update/add_trainees/empty_templates_controller.rb 62.50% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4906      +/-   ##
==========================================
- Coverage   96.10%   96.09%   -0.02%     
==========================================
  Files         743      746       +3     
  Lines       16050    16078      +28     
==========================================
+ Hits        15425    15450      +25     
- Misses        625      628       +3     
Flag Coverage Δ
unittests 96.09% <66.66%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@stevehook stevehook force-pushed the 7942-add-the-empty-csv-file-and-link-it-from-bulk-trainee-upload-pages branch from c7a3c9b to 62996cb Compare December 31, 2024 13:45
@stevehook stevehook force-pushed the 7942-add-the-empty-csv-file-and-link-it-from-bulk-trainee-upload-pages branch from 62996cb to fa440b9 Compare December 31, 2024 13:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants