Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7948] Remove hard-coded sign_off_period settings #4908

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

tomtrentham
Copy link
Contributor

Context

Trello card

Changes proposed in this pull request

  • Remove hard-coded sign_off_period settings

Guidance to review

  • Does the correct content appear?

Important business

  • Does this PR introduce any PII fields that need to be overwritten or deleted in db/scripts/sanitise.sql?
  • Does this PR change the database schema? If so, have you updated the config/analytics.yml file and considered whether you need to send 'import_entity' events?
  • Do we need to send any updates to DQT as part of the work in this PR?
  • Does this PR need an ADR?

NB: Please notify the #twd_data_insights team and ask for a review if new fields are being added to analytics.yml

@tomtrentham tomtrentham added DO NOT MERGE Things could break if this gets merged deploy labels Dec 20, 2024
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.17%. Comparing base (07229a8) to head (53e16d7).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4908      +/-   ##
==========================================
+ Coverage   96.11%   96.17%   +0.06%     
==========================================
  Files         745      745              
  Lines       16069    16066       -3     
==========================================
+ Hits        15444    15451       +7     
+ Misses        625      615      -10     
Flag Coverage Δ
unittests 96.17% <ø> (+0.06%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarqubecloud bot commented Jan 7, 2025

@tomtrentham tomtrentham removed the DO NOT MERGE Things could break if this gets merged label Jan 9, 2025
@tomtrentham tomtrentham merged commit 94d5c54 into main Jan 9, 2025
36 checks passed
@tomtrentham tomtrentham deleted the 7948-reset-sign-off-period-settings branch January 9, 2025 11:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants