Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cl/facet fixes #46

Merged
merged 10 commits into from
Sep 12, 2024
Merged

Cl/facet fixes #46

merged 10 commits into from
Sep 12, 2024

Conversation

CathLass
Copy link
Collaborator

request facets and pass through to use-case response

CathLass
CathLass commented Sep 11, 2024
View reviewed changes
Copy link
Collaborator Author

@CathLass CathLass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some xml comment warnings
are we testing the new functionality added to the use-case and the adaptor? (I've run out of concentration)

Dfe.Data.SearchPrototype/Common/Dfe.Data.SearchPrototype.Common.csproj Outdated Show resolved Hide resolved
Dfe.Data.SearchPrototype/Dfe.Data.SearchPrototype.csproj Outdated Show resolved Hide resolved
Dfe.Data.SearchPrototype/Infrastructure/Dfe.Data.SearchPrototype.Infrastructure.csproj Outdated Show resolved Hide resolved
@CathLass CathLass merged commit cd946a1 into main Sep 12, 2024
2 checks passed
@CathLass CathLass deleted the CL/facet-fixes branch September 26, 2024 10:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AsiaWi AsiaWi AsiaWi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@CathLass @AsiaWi @spencerohegartyDfE