Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[692] New service template improvements #114

Merged
merged 6 commits into from
Nov 21, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions templates/new_service/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,4 @@ terraform/application/vendor
terraform/domains/environment_domains/vendor
terraform.tfstate*
bin/terrafile
bin/konduit.sh
8 changes: 4 additions & 4 deletions templates/new_service/Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -87,10 +87,10 @@ domains-infra-init: bin/terrafile domains composed-variables set-azure-account
-backend-config=storage_account_name=${STORAGE_ACCOUNT_NAME} \
-backend-config=key=domains_infrastructure.tfstate

domains-infra-plan: domains domains-infra-init ## Terraform plan for DNS infrastructure (zone and front door. Usage: make domains-infra-plan
domains-infra-plan: domains domains-infra-init ## Terraform plan for DNS infrastructure (DNS zone and front door). Usage: make domains-infra-plan
terraform -chdir=terraform/domains/infrastructure plan -var-file config/zones.tfvars.json

domains-infra-apply: domains domains-infra-init ## Terraform apply for DNS infrastructure (zone and front door). Usage: make domains-infra-apply
domains-infra-apply: domains domains-infra-init ## Terraform apply for DNS infrastructure (DNS zone and front door). Usage: make domains-infra-apply
terraform -chdir=terraform/domains/infrastructure apply -var-file config/zones.tfvars.json ${AUTO_APPROVE}

domains-init: bin/terrafile domains composed-variables set-azure-account
Expand All @@ -101,10 +101,10 @@ domains-init: bin/terrafile domains composed-variables set-azure-account
-backend-config=storage_account_name=${STORAGE_ACCOUNT_NAME} \
-backend-config=key=${ENVIRONMENT}.tfstate

domains-plan: domains-init ## Terraform plan for DNS environment domains. Usage: make development domains domains-plan
domains-plan: domains-init ## Terraform plan for DNS environment domains. Usage: make development domains-plan
terraform -chdir=terraform/domains/environment_domains plan -var-file config/${CONFIG}.tfvars.json

domains-apply: domains-init ## Terraform apply for DNS environment domains. Usage: make development domains domains-apply
domains-apply: domains-init ## Terraform apply for DNS environment domains. Usage: make development domains-apply
terraform -chdir=terraform/domains/environment_domains apply -var-file config/${CONFIG}.tfvars.json ${AUTO_APPROVE}

test-cluster:
Expand Down
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
aks:
source: "https://github.com/DFE-Digital/terraform-modules"
version: "main"
version: "testing"
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
aks:
source: "https://github.com/DFE-Digital/terraform-modules"
version: "main"
version: "stable"
1 change: 1 addition & 0 deletions templates/new_service/terraform/application/database.tf
Original file line number Diff line number Diff line change
Expand Up @@ -28,4 +28,5 @@ module "redis-cache" {
use_azure = var.deploy_azure_backing_services
azure_enable_monitoring = var.enable_monitoring
azure_patch_schedule = [{ "day_of_week" : "Sunday", "start_hour_utc" : 01 }]
server_version = "6"
}
2 changes: 1 addition & 1 deletion templates/new_service/terraform/application/output.tf
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
output "url" {
value = "https://${module.web_application.hostname}/"
value = module.web_application.url
}
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,7 @@
"hosted_zone": {
"#DNS_ZONE_NAME#": {
"caa_records": {},
"txt_records": {
"_dmarc": {
"value": "v=DMARC1;p=reject;sp=reject;adkim=s;aspf=s;fo=1;rua=mailto:[email protected],mailto:[email protected];ruf=mailto:[email protected]"
}
},
"txt_records": {},
"resource_group_name": "#DOMAINS_RESOURCE_GROUP_NAME#",
"front_door_name": "#FRONT_DOOR_NAME#"
}
Expand Down