Changes following PR comments

DFE-Digital · Sep 29, 2023 · 30d7203 · 30d7203
1 parent 32e4f98
commit 30d7203
Showing 1 changed file with 8 additions and 3 deletions.
diff --git a/TeachingRecordSystem/tests/TeachingRecordSystem.TestCommon/CrmTestData.UpdatePerson.cs b/TeachingRecordSystem/tests/TeachingRecordSystem.TestCommon/CrmTestData.UpdatePerson.cs
@@ -14,8 +14,8 @@ public Task UpdatePerson(Action<UpdatePersonBuilder>? configure)
 
     public class UpdatePersonBuilder
     {
-        Guid? _personId = null;
-        (string FirstName, string MiddleName, string LastName)? _updatedName = null;
+        private Guid? _personId = null;
+        private (string FirstName, string MiddleName, string LastName)? _updatedName = null;
 
         public UpdatePersonBuilder WithPersonId(Guid personId)
         {
@@ -41,7 +41,12 @@ public UpdatePersonBuilder WithUpdatedName(string firstName, string middleName,
 
         public async Task Execute(CrmTestData testData)
         {
-            if (_personId is not null && _updatedName is not null)
+            if (_personId is null)
+            {
+                throw new InvalidOperationException("WithPersonId has not been set");
+            }
+
+            if (_updatedName is not null)
             {
                 await testData.OrganizationService.ExecuteAsync(new UpdateRequest()
                 {