Tweaks from PR comments

DFE-Digital · Sep 29, 2023 · 787bb69 · 787bb69
1 parent d13c5b6
commit 787bb69
Show file tree

Hide file tree

Showing 3 changed files with 11 additions and 8 deletions.
diff --git a/TeachingRecordSystem/src/TeachingRecordSystem.SupportUi/Pages/Persons/Index.cshtml b/TeachingRecordSystem/src/TeachingRecordSystem.SupportUi/Pages/Persons/Index.cshtml
@@ -60,8 +60,8 @@
                             <tr class="govuk-table__row" data-testid="[email protected]">
                                 <td class="govuk-table__cell" data-testid="name"><a href="@LinkGenerator.PersonDetail(personInfo.PersonId, search: Model.Search, sortBy: Model.SortBy, pageNumber: Model.PageNumber)" class="govuk-link">@personInfo.Name</a></td>
                                 <td class="govuk-table__cell" data-testid="date-of-birth" use-empty-fallback>@(personInfo.DateOfBirth.HasValue ? personInfo.DateOfBirth.Value.ToString("dd/MM/yyyy") : string.Empty)</td>
-                                <td class="govuk-table__cell" data-testid="trn"><span use-empty-fallback>@personInfo.Trn</span></td>
-                                <td class="govuk-table__cell" data-testid="nino"><span use-empty-fallback>@personInfo.NationalInsuranceNumber</span></td>
+                                <td class="govuk-table__cell" data-testid="trn" use-empty-fallback>@personInfo.Trn</td>
+                                <td class="govuk-table__cell" data-testid="nino" use-empty-fallback>@personInfo.NationalInsuranceNumber</td>
                             </tr>
                         }
                     }

diff --git a/TeachingRecordSystem/src/TeachingRecordSystem.SupportUi/Pages/Persons/Index.cshtml.cs b/TeachingRecordSystem/src/TeachingRecordSystem.SupportUi/Pages/Persons/Index.cshtml.cs
@@ -21,8 +21,7 @@ public partial class IndexModel : PageModel
 
     public IndexModel(
         TrsLinkGenerator linkGenerator,
-        ICrmQueryDispatcher crmQueryDispatcher,
-        IConfiguration configuration)
+        ICrmQueryDispatcher crmQueryDispatcher)
     {
         _linkGenerator = linkGenerator;
         _crmQueryDispatcher = crmQueryDispatcher;

diff --git a/...ngRecordSystem/src/TeachingRecordSystem.SupportUi/Pages/Persons/PersonDetail/Index.cshtml b/...ngRecordSystem/src/TeachingRecordSystem.SupportUi/Pages/Persons/PersonDetail/Index.cshtml
@@ -31,13 +31,17 @@
         </govuk-summary-list-row>
         @if (Model.Person.PreviousNames.Length > 0)
         {
+            <govuk-summary-list-row>
+                <govuk-summary-list-row-key>Previous name(s)</govuk-summary-list-row-key>
+                <govuk-summary-list-row-value>
+                    <ul class="govuk-list">
             @for (int i = 0; i < Model.Person.PreviousNames.Length; i++)
             {
-                <govuk-summary-list-row>
-                    <govuk-summary-list-row-key>@(i == 0 ? "Previous name(s)" : string.Empty)</govuk-summary-list-row-key>
-                    <govuk-summary-list-row-value data-testid="personal-details-previous-names-@i">@Model.Person.PreviousNames[i]</govuk-summary-list-row-value>
-                </govuk-summary-list-row>
+                        <li data-testid="personal-details-previous-names-@i">@Model.Person.PreviousNames[i]</li>                
             }
+                    </ul>
+                </govuk-summary-list-row-value>
+            </govuk-summary-list-row>
         }
         <govuk-summary-list-row>
             <govuk-summary-list-row-key>Date of birth</govuk-summary-list-row-key>