Fix checking for null on an empty array (#1231)

DFE-Digital · Mar 8, 2024 · 8ef961a · 8ef961a
1 parent 3e1b761
commit 8ef961a
Showing 1 changed file with 2 additions and 2 deletions.
diff --git a/TeachingRecordSystem/src/TeachingRecordSystem.Core/Dqt/DataverseAdapter.CreateTeacher.cs b/TeachingRecordSystem/src/TeachingRecordSystem.Core/Dqt/DataverseAdapter.CreateTeacher.cs
@@ -50,7 +50,7 @@ public async Task<CreateTeacherResult> CreateTeacher(CreateTeacherCommand comman
         helper.FlagBadData(txnRequest);
 
         var findExistingTeacherResult = await (findExistingTeacher ?? helper.FindExistingTeacher)();
-        var allocateTrn = findExistingTeacherResult == null;
+        var allocateTrn = findExistingTeacherResult.Length > 0;
         string trn = null;
 
         if (allocateTrn)
@@ -366,7 +366,7 @@ public async Task<CreateTeacherDuplicateTeacherResult[]> FindExistingTeacher()
             else
             {
                 // Not enough data in the input to match on
-                return null;
+                return Array.Empty<CreateTeacherDuplicateTeacherResult>();
             }
 
             var query = new QueryExpression(Contact.EntityLogicalName)