Allow updating users with no roles (#1646)

DFE-Digital · Nov 4, 2024 · a60d245 · a60d245
1 parent 24c9317
commit a60d245
Show file tree

Hide file tree

Showing 2 changed files with 0 additions and 27 deletions.
diff --git a/TeachingRecordSystem/src/TeachingRecordSystem.SupportUi/Pages/Users/EditUser.cshtml.cs b/TeachingRecordSystem/src/TeachingRecordSystem.SupportUi/Pages/Users/EditUser.cshtml.cs
@@ -67,11 +67,6 @@ public async Task<IActionResult> OnPost()
         // Sanitize roles
         var newRoles = Roles!.Where(r => UserRoles.All.Contains(r)).ToArray();
 
-        if (Roles?.Length == 0)
-        {
-            ModelState.AddModelError(nameof(Roles), "Select at least one role");
-        }
-
         if (!ModelState.IsValid)
         {
             return this.PageWithErrors();

diff --git a/...gRecordSystem/tests/TeachingRecordSystem.SupportUi.Tests/PageTests/Users/EditUserTests.cs b/...gRecordSystem/tests/TeachingRecordSystem.SupportUi.Tests/PageTests/Users/EditUserTests.cs
@@ -184,28 +184,6 @@ public async Task Post_NoName_RendersError()
         await AssertEx.HtmlResponseHasError(response, "Name", "Enter a name");
     }
 
-    [Fact]
-    public async Task Post_NoRolesSelected_RendersError()
-    {
-        // Arrange
-        var user = await TestData.CreateUser();
-        var newName = Faker.Name.FullName();
-
-        var request = new HttpRequestMessage(HttpMethod.Post, GetRequestPath(user.UserId))
-        {
-            Content = new FormUrlEncodedContentBuilder()
-            {
-                { "Name", newName },
-            }
-        };
-
-        // Act
-        var response = await HttpClient.SendAsync(request);
-
-        // Assert
-        await AssertEx.HtmlResponseHasError(response, "Roles", "Select at least one role");
-    }
-
     [Theory]
     [InlineData(true, false, true, UserUpdatedEventChanges.Name)]
     [InlineData(false, true, true, UserUpdatedEventChanges.Roles)]