Added support for showing MQ deleted events in change log #1060
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 similar comment
gunndabad
reviewed
Jan 5, 2024
...cordSystem/src/TeachingRecordSystem.SupportUi/Pages/Persons/PersonDetail/ChangeLog.cshtml.cs
Outdated
Show resolved
Hide resolved
gunndabad
reviewed
Jan 5, 2024
...cordSystem/src/TeachingRecordSystem.SupportUi/Pages/Persons/PersonDetail/ChangeLog.cshtml.cs
Outdated
Show resolved
Hide resolved
gunndabad
reviewed
Jan 5, 2024
...c/TeachingRecordSystem.SupportUi/Pages/Persons/PersonDetail/Timeline/Events/EventWithUser.cs
Outdated
Show resolved
Hide resolved
gunndabad
reviewed
Jan 5, 2024
TeachingRecordSystem/tests/TeachingRecordSystem.TestCommon/TestData.UpdateQualification.cs
Outdated
Show resolved
Hide resolved
gunndabad
reviewed
Jan 5, 2024
.../tests/TeachingRecordSystem.SupportUi.Tests/PageTests/Persons/PersonDetail/ChangeLogTests.cs
Outdated
Show resolved
Hide resolved
gunndabad
reviewed
Jan 5, 2024
...rc/TeachingRecordSystem.SupportUi/Pages/Persons/PersonDetail/Timeline/Events/RaisedByUser.cs
Outdated
Show resolved
Hide resolved
gunndabad
reviewed
Jan 5, 2024
...c/TeachingRecordSystem.SupportUi/Pages/Persons/PersonDetail/Timeline/Events/EventWithUser.cs
Outdated
Show resolved
Hide resolved
Removed tabs Added filter to only get MQ deleted events for the moment Amendments following PR comments Removed unused properties
hortha
force-pushed
the
show-deleted-mq-events-in-change-log
branch
from
f0accda to
9cf425a
Compare
gunndabad
approved these changes
Jan 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Users need to be able to see that an MQ has been deleted from a teaching record and the details of that MQ.
Changes proposed in this pull request
Update the change log to query MandatoryQualifictionDeletedEvents for the current person and render each entry within the timeline according to the Figma designs.
Guidance to review
Changes to UI + tests
Checklist