Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UserMerged Webhook #1219

Merged
merged 1 commit into from
Mar 5, 2024
Merged

UserMerged Webhook #1219

merged 1 commit into from
Mar 5, 2024

Conversation

MrKevJoy
Copy link
Contributor

@MrKevJoy MrKevJoy commented Mar 4, 2024

https://trello.com/c/ZUEeQ5IT/1833-allow-deactivating-dqt-record-linked-to-deactivated-id-account

When a user is merged, the subordinate currently cannot be de-activated in crm because it still retains the tsPersonId. This change amends the webhook so that the tspersonid is cleared when a record is merged. This will enable the dqt record in crm to be de-activated.

  • Attach to Trello card
  • Rebased master
  • Cleaned commit history
  • Tested by running locally

@MrKevJoy MrKevJoy force-pushed the deactivate-teacher-webhook branch 3 times, most recently from 64c90be to 460fe0b Compare March 5, 2024 09:26
@MrKevJoy MrKevJoy marked this pull request as ready for review March 5, 2024 09:27
@MrKevJoy MrKevJoy requested a review from gunndabad March 5, 2024 09:27
@MrKevJoy MrKevJoy changed the title When a user is merged with another, remove tsPersonId of the subordin… UserMerged Webhook Mar 5, 2024
@MrKevJoy MrKevJoy force-pushed the deactivate-teacher-webhook branch from 460fe0b to cbc8f44 Compare March 5, 2024 09:59
@MrKevJoy MrKevJoy merged commit 4a10fa2 into main Mar 5, 2024
12 checks passed
@MrKevJoy MrKevJoy deleted the deactivate-teacher-webhook branch March 5, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants