Allow HE quals with no link to dfeta_hequalification table #1253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hortha
force-pushed
the
fix-returning-he-quals-from-api
branch
from
cf9b06c to
fabb1ea
Compare
gunndabad
reviewed
Apr 2, 2024
TeachingRecordSystem/tests/TeachingRecordSystem.Api.Tests/V3/V20240101/GetTeacherTestBase.cs
Outdated
Show resolved
Hide resolved
hortha
force-pushed
the
fix-returning-he-quals-from-api
branch
from
fd4e865 to
5805e8c
Compare
gunndabad
approved these changes
Apr 3, 2024
Amended to only return HE quals with at least one subject + added tests Removed commented out code Removed unnecessary code Removed commented out code
hortha
force-pushed
the
fix-returning-he-quals-from-api
branch
from
713726b to
c970f68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
The V3 API returns HE quals but we’re currently filtering out those without a populated dfeta_hequalification.dfeta_name
Changes proposed in this pull request
Amend the API to not require the field to be populated (return null instead).
Addtionally, do no return HE quals whicha have 0 HE subjects associated with them.