Add One Login header #1262
Merged
Add One Login header #1262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gunndabad
commented
Apr 4, 2024
| @@ -155,15 +155,6 @@ void IConfigureNamedOptions<OneLoginOptions>.Configure(string? name, OneLoginOpt | |||
|
|
|||
| options.SignInScheme = AuthenticationSchemes.FormFlowJourney; | |||
|
|
|||
| options.Events.OnRedirectToIdentityProvider = context => | |||
There was a problem hiding this comment.
This is no longer required since a) One Login has increased the maximum size of URLs they accept and 2) we're no longer passing AuthenticationProperties along.
gunndabad
force-pushed
the
onelogin-header
branch
from
d113da9 to
0da3771
Compare
gunndabad
force-pushed
the
onelogin-header
branch
from
0da3771 to
c67997c
Compare
gunndabad
force-pushed
the
onelogin-header
branch
2 times, most recently
from
b2f45bd to
78ca514
Compare
gunndabad
force-pushed
the
onelogin-header
branch
from
78ca514 to
106184f
Compare
gunndabad
force-pushed
the
onelogin-header
branch
from
106184f to
179506d
Compare
gunndabad
force-pushed
the
onelogin-header
branch
from
179506d to
a1e1b33
Compare
gunndabad
force-pushed
the
onelogin-header
branch
from
a1e1b33 to
37c0b5f
Compare
gunndabad
force-pushed
the
onelogin-header
branch
from
37c0b5f to
3ed4f55
Compare
gunndabad
force-pushed
the
onelogin-header
branch
from
3ed4f55 to
bc8c1ab
Compare
gunndabad
force-pushed
the
onelogin-header
branch
from
bc8c1ab to
57ed42b
Compare
gunndabad
force-pushed
the
onelogin-header
branch
from
57ed42b to
5a7d07b
Compare
MrKevJoy
approved these changes
Apr 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This also adds a separate sign out page that we can use during our matching journeys.