-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Induction journey #1748
Merged
Merged
Induction journey #1748
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CathLass
commented
Dec 16, 2024
...src/TeachingRecordSystem.SupportUi/Pages/Persons/PersonDetail/EditInduction/Status.cshtml.cs
Show resolved
Hide resolved
gunndabad
reviewed
Dec 17, 2024
gunndabad
reviewed
Dec 17, 2024
TeachingRecordSystem/src/TeachingRecordSystem.Core/Models/InductionStatus.cs
Outdated
Show resolved
Hide resolved
gunndabad
reviewed
Dec 17, 2024
TeachingRecordSystem/src/TeachingRecordSystem.Core/Models/InductionStatus.cs
Outdated
Show resolved
Hide resolved
gunndabad
reviewed
Dec 17, 2024
TeachingRecordSystem/src/TeachingRecordSystem.Core/Models/InductionStatus.cs
Outdated
Show resolved
Hide resolved
gunndabad
reviewed
Dec 17, 2024
...TeachingRecordSystem.SupportUi/Pages/Persons/PersonDetail/EditInduction/CommonJourneyPage.cs
Outdated
Show resolved
Hide resolved
gunndabad
reviewed
Dec 17, 2024
...TeachingRecordSystem.SupportUi/Pages/Persons/PersonDetail/EditInduction/CommonJourneyPage.cs
Outdated
Show resolved
Hide resolved
gunndabad
reviewed
Dec 17, 2024
...eachingRecordSystem.SupportUi/Pages/Persons/PersonDetail/EditInduction/EditInductionState.cs
Outdated
Show resolved
Hide resolved
gunndabad
reviewed
Dec 17, 2024
...chingRecordSystem.SupportUi/Pages/Persons/PersonDetail/EditInduction/InductionJourneyPage.cs
Show resolved
Hide resolved
gunndabad
reviewed
Dec 17, 2024
...chingRecordSystem.SupportUi/Pages/Persons/PersonDetail/EditInduction/InductionJourneyPage.cs
Outdated
Show resolved
Hide resolved
gunndabad
reviewed
Dec 17, 2024
...em/src/TeachingRecordSystem.SupportUi/Pages/Persons/PersonDetail/EditInduction/Status.cshtml
Outdated
Show resolved
Hide resolved
gunndabad
reviewed
Dec 17, 2024
...RecordSystem.SupportUi.Tests/PageTests/Persons/PersonDetail/EditInduction/CommonPageTests.cs
Outdated
Show resolved
Hide resolved
gunndabad
reviewed
Dec 17, 2024
...RecordSystem.SupportUi.Tests/PageTests/Persons/PersonDetail/EditInduction/CommonPageTests.cs
Outdated
Show resolved
Hide resolved
gunndabad
reviewed
Dec 17, 2024
...RecordSystem.SupportUi.Tests/PageTests/Persons/PersonDetail/EditInduction/CommonPageTests.cs
Outdated
Show resolved
Hide resolved
gunndabad
reviewed
Dec 17, 2024
...RecordSystem.SupportUi.Tests/PageTests/Persons/PersonDetail/EditInduction/CommonPageTests.cs
Outdated
Show resolved
Hide resolved
gunndabad
reviewed
Dec 17, 2024
...RecordSystem.SupportUi.Tests/PageTests/Persons/PersonDetail/EditInduction/CommonPageTests.cs
Outdated
Show resolved
Hide resolved
gunndabad
reviewed
Dec 17, 2024
...tem.SupportUi.Tests/PageTests/Persons/PersonDetail/EditInduction/EditInductionStatusTests.cs
Show resolved
Hide resolved
gunndabad
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
https://trello.com/c/0LaMQ0ih/635-inductions-dev-skeleton-journey
Changes proposed in this pull request
It's the main journey from editing the induction status onwards. Shortcuts into the journey will be added later, i.e. requirement to edit start date / completed date / exemption reason from the induction tab. They follow the same journey but just jump into it mid-way.
Guidance to review
I've used the same buttons as for Alerts journeys
, although the page designs show a button and a link
The Induction journey for editing an induction