Removed audit primary Id attributes from audit NewValue and OldValue properties #1787
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gunndabad
approved these changes
Jan 3, 2025
hortha
force-pushed
the
fix-sync-audit-issue-where-id-is-seen-as-changed
branch
from
44b060b to
7df1e69
Compare
hortha
force-pushed
the
fix-sync-audit-issue-where-id-is-seen-as-changed
branch
from
7df1e69 to
334785a
Compare
hortha
force-pushed
the
fix-sync-audit-issue-where-id-is-seen-as-changed
branch
2 times, most recently
from
5903654 to
491718b
Compare
hortha
force-pushed
the
fix-sync-audit-issue-where-id-is-seen-as-changed
branch
from
491718b to
af59dad
Compare
…properties which get wrongly set during derialization from XML. Fixed linting issues Reduced page size to try and fix timeout errors saving events Increase timeout when saving events for induction sync Amended to only get entity versions for attributes we are interested in
hortha
force-pushed
the
fix-sync-audit-issue-where-id-is-seen-as-changed
branch
from
69a2b37 to
f2fcc0a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to us needing to store audit history as serialized XML in blob storage, the deserialization was incorrectly setting the primary Id attributes for the NewValue and OldValue properties (making it seem like they had changed).
This change removes them after they have been deserialized.