Alert detail page #849
Merged
Alert detail page #849
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gunndabad
reviewed
Oct 4, 2023
TeachingRecordSystem/src/TeachingRecordSystem.SupportUi/Pages/Alerts/Alert/Index.cshtml
Outdated
Show resolved
Hide resolved
gunndabad
reviewed
Oct 4, 2023
TeachingRecordSystem/src/TeachingRecordSystem.SupportUi/Pages/Alerts/Alert/Index.cshtml.cs
Outdated
Show resolved
Hide resolved
gunndabad
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
Users of the TRS Console need to be able to view details of alerts.
Changes proposed in this pull request
Populate the /alerts/{alertId} page following the designs within the ‘Closed alert’ section ofthe Figma design (note that active alerts should be visible here too).
If no alert exists with the specified alertId return a 404.
The back link should go back to /persons/{personId}/alerts where {personId} is the ID of the person linked to the current alert.
Guidance to review
CRM queries + UI + tests
Excluding detaillink functionality at the moment until CRM changes are done.
Checklist