Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add details link to alert detail page #853

Merged
merged 4 commits into from
Oct 6, 2023

Conversation

hortha
Copy link
Contributor

@hortha hortha commented Oct 6, 2023

Context

In the TRS Console we want to allow users to add a link to an external system that holds details for alerts (e.g. TMS) so that users don’t have to copy/paste lots of text from that external system.

Changes proposed in this pull request

Amend the existing /alerts/{alertId} page following the designs within the ‘Closed alert’ section of the Figma design.

If the corresponding CRM alert has a DetailLink attribute, create the ‘See full case details (opens in new tab)' link using the DetailLink attribute as the link’s href

Guidance to review

Relatively simple change

Checklist

  • Attach to Trello card
  • Rebased master
  • Cleaned commit history
  • Tested by running locally

@hortha hortha requested a review from gunndabad October 6, 2023 08:50
@hortha
Copy link
Contributor Author

hortha commented Oct 6, 2023

@hortha hortha temporarily deployed to dev_aks October 6, 2023 08:58 — with GitHub Actions Inactive
@hortha hortha temporarily deployed to dev_aks October 6, 2023 10:02 — with GitHub Actions Inactive
@hortha hortha merged commit 53be793 into main Oct 6, 2023
11 checks passed
@hortha hortha deleted the add-details-link-to-alert-detail-page branch October 6, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants