Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an mq in trs #929

Merged
merged 1 commit into from
Dec 7, 2023
Merged

Add an mq in trs #929

merged 1 commit into from
Dec 7, 2023

Conversation

hortha
Copy link
Contributor

@hortha hortha commented Nov 23, 2023

Context

As a Support team user
I want to be able to add an MQ (Mandatory Qualification) award in TRS
So that I can make sure a teaching record has the correct award allocated.

Changes proposed in this pull request

Changes to UI to be able to Add an MQ + supporting backend changes to save to CRM.

Guidance to review

CRM changes + UI + Tests

Checklist

  • Attach to Trello card
  • Rebased master
  • Cleaned commit history
  • Tested by running locally

@hortha hortha requested a review from gunndabad November 23, 2023 13:33
@hortha
Copy link
Contributor Author

hortha commented Nov 23, 2023

Add an MQ in TRS

Added CRM related tests

Added UI tests

Fixed file corruption caused by rebase

Fixed PR issues

Fixed PR issues

Tweaked filter requiring a personId

Tweaks based on updated designs

Added support for dfeta_trsdeletedevent field in CRM dfeta_qualification table

Regenerated CRM code
@hortha hortha merged commit 7716cd7 into main Dec 7, 2023
11 checks passed
@hortha hortha deleted the add-an-mq-in-trs branch December 7, 2023 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants