Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EventId property to EventBase #987

Merged
merged 1 commit into from
Dec 14, 2023
Merged

Add EventId property to EventBase #987

merged 1 commit into from
Dec 14, 2023

Conversation

gunndabad
Copy link
Collaborator

Part 1 of N of adding an EventId property to EventBase (so the serialized event always has an ID in it and that ID can be generated outside of the DB).

Adding a required property here is safe as we don't read back events anywhere yet.

@gunndabad gunndabad marked this pull request as ready for review December 13, 2023 17:16
@gunndabad gunndabad merged commit e52ac1d into main Dec 14, 2023
10 checks passed
@gunndabad gunndabad deleted the fix-event-ids branch December 14, 2023 11:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hortha hortha hortha approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gunndabad @hortha