convert to jbuilder, restrict API routes to JSON only

app/controllers/publishers/vacancies/documents_controller.rb

@@ -32,24 +32,26 @@ def destroy
   end
 
   def upload_file
-    document = params.require(:documents)
-
-    if vacancy.supporting_documents.attach(document)
-      upload_success document
-    else
-      upload_failure document
+    @document = params.require(:documents)
+
+    respond_to do |format|
+      if vacancy.supporting_documents.attach(@document)
+        send_dfe_analytics_event(:supporting_document_created, @document.original_filename, @document.size, @document.content_type)
+        format.json { render "upload_success" }
+      else
+        format.json { render "upload_error" }
+      end
     end
   end
 
   def delete_uploaded_file
-    vacancy.supporting_documents.select { |d| d.filename == params.require(:delete) }.each do |document|
+    filename = params.require(:delete)
+    vacancy.supporting_documents.select { |d| d.filename == filename }.each do |document|
       document.purge
       send_dfe_analytics_event(:supporting_document_deleted, document.filename, document.byte_size, document.content_type)
     end
 
-    render json: {
-      success: true,
-    }
+    respond_to(&:json)
   end
 
   def confirm
@@ -64,25 +66,8 @@ def confirm
 
   private
 
-  def upload_success(document)
-    send_dfe_analytics_event(:supporting_document_created, document.original_filename, document.size, document.content_type)
-    render json: {
-      success: {
-        messageHtml: t("jobs.file_upload_success_message", filename: document.original_filename),
-        messageText: t("jobs.file_upload_success_message", filename: document.original_filename),
-      },
-      file: {
-        filename: document.original_filename,
-        originalname: document.original_filename,
-      },
-    }
-  end
-
-  def upload_failure(document)
-    render json: {
-      error: {
-        message: "#{document.original_filename} #{vacancy.errors[:supporting_documents].first}",
-      },
+  def file_json(document)
+    {
       file: {
         filename: document.original_filename,
         originalname: document.original_filename,

app/views/publishers/vacancies/documents/_file.json.jbuilder

@@ -0,0 +1,4 @@
+json.file do
+  json.filename document.original_filename
+  json.orginalname document.original_filename
+end

app/views/publishers/vacancies/documents/delete_uploaded_file.json.jbuilder

@@ -0,0 +1 @@
+json.success true

app/views/publishers/vacancies/documents/upload_error.json.jbuilder

@@ -0,0 +1,4 @@
+json.error do
+  json.message "#{@document.original_filename} #{vacancy.errors[:supporting_documents].first}"
+end
+json.partial! "file", document: @document

app/views/publishers/vacancies/documents/upload_success.json.jbuilder

@@ -0,0 +1,5 @@
+json.success do
+  json.messageHtml t("jobs.file_upload_success_message", filename: @document.original_filename)
+  json.messageText t("jobs.file_upload_success_message", filename: @document.original_filename)
+end
+json.partial! "file", document: @document

config/routes.rb

@@ -356,8 +356,9 @@
       resources :build, only: %i[show update], controller: "publishers/vacancies/build"
       resources :documents, only: %i[index new create destroy], controller: "publishers/vacancies/documents" do
         post :confirm, on: :collection
-        post "/upload", on: :collection, to: "publishers/vacancies/documents#upload_file"
-        post "/remove", on: :collection, to: "publishers/vacancies/documents#delete_uploaded_file"
+        # API for MoJ multi-select component
+        post :upload, on: :collection, to: "publishers/vacancies/documents#upload_file", format: 'json'
+        post :remove, on: :collection, to: "publishers/vacancies/documents#delete_uploaded_file", format: 'json'
       end
       resource :application_forms, only: %i[create destroy], controller: "publishers/vacancies/application_forms"