-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Faith Schools Flow Target branch #7230
base: main
Are you sure you want to change the base?
Conversation
b05a974
to
b2c49e7
Compare
d03f02e
to
7ebf923
Compare
c22557f
to
3528559
Compare
08ab7a0
to
4144574
Compare
Co-authored-by: EllieNodder <[email protected]>
Co-authored-by: EllieNodder <[email protected]>
Co-authored-by: EllieNodder <[email protected]>
Co-authored-by: EllieNodder <[email protected]>
Co-authored-by: EllieNodder <[email protected]>
Co-authored-by: EllieNodder <[email protected]>
catholic_following_religion: | ||
heading: Religious information | ||
title: Religious information — Application | ||
is_a_catholic_school: "%{name} is a Catholic school." | ||
preference_to_catholics: Schools, academies and colleges of a religious character can give preference to Catholic applicants when recruiting for teaching roles. | ||
preference_for_support_staff: They can also give preference to Catholic applicants for support staff roles where there is a genuine occupational requirement. | ||
non_catholics_apply: Applicants who do not follow a faith or religion are still encouraged to apply. | ||
non_catholic_following_religion: | ||
heading: Religious information | ||
title: Religious information — Application | ||
catholic_religion_details: | ||
heading: Religious information | ||
title: Religious information — Application | ||
non_catholic_religion_details: | ||
heading: Religious information | ||
title: Religious information — Application | ||
school_ethos: | ||
heading: Religious information | ||
title: Religious information — Application | ||
has_a_religious_character: "%{name} has a religious character." | ||
preference_to_religious_applicants: Schools, academies and colleges of a religious character can give preference to religious applicants when recruiting for teaching roles, but candidates who do not follow a faith or religion are still encouraged to apply. | ||
ethos_and_aims: How will you support the school's ethos and aims? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggestion 💡
The bit repeating across all the blocks could be extracted and re-used using YAML anchors.
Something like the example bellow. Or the anchor could be defined in one of the steps that only has header/title and reused without having to be defined separately:
catholic_following_religion: | |
heading: Religious information | |
title: Religious information — Application | |
is_a_catholic_school: "%{name} is a Catholic school." | |
preference_to_catholics: Schools, academies and colleges of a religious character can give preference to Catholic applicants when recruiting for teaching roles. | |
preference_for_support_staff: They can also give preference to Catholic applicants for support staff roles where there is a genuine occupational requirement. | |
non_catholics_apply: Applicants who do not follow a faith or religion are still encouraged to apply. | |
non_catholic_following_religion: | |
heading: Religious information | |
title: Religious information — Application | |
catholic_religion_details: | |
heading: Religious information | |
title: Religious information — Application | |
non_catholic_religion_details: | |
heading: Religious information | |
title: Religious information — Application | |
school_ethos: | |
heading: Religious information | |
title: Religious information — Application | |
has_a_religious_character: "%{name} has a religious character." | |
preference_to_religious_applicants: Schools, academies and colleges of a religious character can give preference to religious applicants when recruiting for teaching roles, but candidates who do not follow a faith or religion are still encouraged to apply. | |
ethos_and_aims: How will you support the school's ethos and aims? | |
religious_information: &religious_information | |
heading: Religious information | |
title: Religious information — Application | |
catholic_following_religion: | |
<<: *religious_information | |
is_a_catholic_school: "%{name} is a Catholic school." | |
preference_to_catholics: Schools, academies and colleges of a religious character can give preference to Catholic applicants when recruiting for teaching roles. | |
preference_for_support_staff: They can also give preference to Catholic applicants for support staff roles where there is a genuine occupational requirement. | |
non_catholics_apply: Applicants who do not follow a faith or religion are still encouraged to apply. | |
non_catholic_following_religion: *religious_information | |
catholic_religion_details: *religious_information | |
non_catholic_religion_details: *religious_information | |
school_ethos: | |
<<: *religious_information | |
has_a_religious_character: "%{name} has a religious character." | |
preference_to_religious_applicants: Schools, academies and colleges of a religious character can give preference to religious applicants when recruiting for teaching roles, but candidates who do not follow a faith or religion are still encouraged to apply. | |
ethos_and_aims: How will you support the school's ethos and aims? |
- following_religion | ||
- religious_reference_type | ||
- faith | ||
- place_of_worship | ||
- religious_referee_name | ||
- religious_referee_address | ||
- religious_referee_role | ||
- religious_referee_email | ||
- religious_referee_phone | ||
- baptism_address | ||
- baptism_date | ||
- ethos_and_aims |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🙋♂️
The majority of these new fields could be considered PII. Adding them to analytics.yml
file will expose them in plain to BigQ Analytics platform.
This list needs to be curated with our data analyst (Brandon) and:
- Fields containing PII that Brandon wants in analytics will also need to be listed in
analytics_hidden_pii.yml
so they get masked before being pushed to BigQ. - Fields containing PII that Brandon doesn't need in BigQ will need to be listed in
analytics_blocklist.yml
instead of here. - Fields not considered PII can be left here.
From the list of new fields here, I would guess the only ones not purely PII are the "following religion" are these three:
- following_religion
- religious_reference_type
- faith
They're still personal sensitive data and one would wonder if they actually could be combined with other fields to identify a particular person.
I guess "following_religion" is generic enough, but I believe the particular faith of an applicant should be masked?
The docs on the gem referencing the different config files usage: https://github.com/DFE-Digital/dfe-analytics?tab=readme-ov-file#5-send-database-events
Trello card URL
Changes in this PR:
Screenshots of UI changes:
Before
After
Next steps:
Terraform deployment required?
New development configuration to be shared?