Attach PDF to submitted job application #7295
Open
+88
−11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review app deployed to https://teaching-vacancies-review-pr-7295.test.teacherservices.cloud on AKS |
starswan
force-pushed
the
attach-pdf-to-submitted-application
branch
from
70ee31c to
65639bc
Compare
starswan
force-pushed
the
attach-pdf-to-submitted-application
branch
from
35b581c to
91074e6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card URL
https://trello.com/c/ELBZvbRJ/1369-enable-hiring-staff-to-bulk-download-received-applications-phase-1
Changes in this PR:
The current process for building PDFs is too slow for batch usage - it takes 1.5 seconds to build each PDF, and around another 500ms to render the result. As a result we need to cache PDF generation at job submission time so that we can bulk download them via our new ATS functionality.
This PR adds a background job to build PDFs for applications as they are submitted, and a rake task to back-fill PDFs into existing job applications.
I'm slightly nervous about how long the back-fill on job PDFs might take - is there a better solution so that we don't have to cache these?
Screenshots of UI changes:
Before
After
Next steps:
Terraform deployment required?
New development configuration to be shared?