Faith school candidate #7335
Open
Faith school candidate #7335
+136
−125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
starswan
force-pushed
the
faith-school-candidate
branch
from
f623d30 to
90935cd
Compare
scruti
reviewed
Dec 6, 2024
| @@ -0,0 +1,61 @@ | |||
| en: | |||
There was a problem hiding this comment.
Nice extracting it to its own locale file 👏
scruti
reviewed
Dec 6, 2024
| @@ -20,8 +20,8 @@ | |||
| = f.govuk_error_summary | |||
|
|
|||
| = f.govuk_radio_buttons_fieldset :following_religion do | |||
| = f.govuk_radio_button :following_religion, true, link_errors: true, label: { text: t("helpers.label.jobseekers_job_application_following_religion_form.following_religion_options.yes") } | |||
| = f.govuk_radio_button :following_religion, false, label: { text: t("helpers.label.jobseekers_job_application_following_religion_form.following_religion_options.no") } | |||
| = f.govuk_radio_button :following_religion, true, link_errors: true | |||
There was a problem hiding this comment.
This is boolean and the "false" bellow is a string. The "true" in the non-catholic view is also a string.
Is this ok?
scruti
reviewed
Dec 6, 2024
| :in_progress | ||
| end | ||
| govuk_tag(text: t("shared.status_tags.#{status}"), colour: STATUS_COLOURS.fetch(status)) | ||
| end |
|
Review app deployed to https://teaching-vacancies-review-pr-7335.test.teacherservices.cloud on AKS |
starswan
force-pushed
the
faith-schools-flow
branch
from
08ab7a0 to
4144574
Compare
starswan
force-pushed
the
faith-school-candidate
branch
from
90935cd to
4626656
Compare
EllieNodder
reviewed
Dec 12, 2024
Co-authored-by: EllieNodder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card URL
https://trello.com/c/WcdDCjEc/1325-faith-schools-add-religious-information-section-ces-flow-top-radio
Changes in this PR:
Fix faith schools candidate flow - specifically around partial entry of form data
Screenshots of UI changes:
Before
After
Next steps:
Terraform deployment required?
New development configuration to be shared?