Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clarity API cookie consent #7443

Merged
merged 3 commits into from
Feb 3, 2025
Merged

clarity API cookie consent #7443

merged 3 commits into from
Feb 3, 2025

Conversation

starswan
Copy link
Contributor

Trello card URL

https://trello.com/c/aeXcAUxZ/1481-cookie-consent-requirements-for-microsoft-clarity

Changes in this PR:

Add call to clarity API for consent

@starswan starswan marked this pull request as ready for review January 24, 2025 10:31
@@ -36,6 +36,7 @@ def footer_links
end

def consented_to_extra_cookies?
cookies["consented-to-additional-cookies-v2"] == "yes" && Rails.configuration.app_role.production?
# consented value can be 'yes' or 'clarity'
cookies["consented-to-additional-cookies-v2"] != "no" && Rails.configuration.app_role.production?
Copy link
Contributor

@ddippolito ddippolito Jan 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't this check for "yes" || "clarity" ?

Copy link
Contributor Author

@starswan starswan Jan 29, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I figured != 'no' was a better check for future proofing - but actually you're right, there is a potential bug here if the consented value isn't set.

Copy link

github-actions bot commented Jan 30, 2025

Review app https://teaching-vacancies-review-pr-7443.test.teacherservices.cloud was successfully deleted

@starswan starswan merged commit 34a7b93 into main Feb 3, 2025
16 checks passed
@starswan starswan deleted the clarity-api-cookie-consent branch February 3, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants