clarity API cookie consent #7443
Merged
+26
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ddippolito
reviewed
Jan 29, 2025
app/helpers/application_helper.rb
Outdated
| @@ -36,6 +36,7 @@ def footer_links | |||
| end | |||
|
|
|||
| def consented_to_extra_cookies? | |||
| cookies["consented-to-additional-cookies-v2"] == "yes" && Rails.configuration.app_role.production? | |||
| # consented value can be 'yes' or 'clarity' | |||
| cookies["consented-to-additional-cookies-v2"] != "no" && Rails.configuration.app_role.production? | |||
There was a problem hiding this comment.
Shouldn't this check for "yes" || "clarity" ?
There was a problem hiding this comment.
I figured != 'no' was a better check for future proofing - but actually you're right, there is a potential bug here if the consented value isn't set.
ddippolito
approved these changes
Jan 29, 2025
scruti
reviewed
Jan 29, 2025
scruti
approved these changes
Jan 29, 2025
|
Review app https://teaching-vacancies-review-pr-7443.test.teacherservices.cloud was successfully deleted |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card URL
https://trello.com/c/aeXcAUxZ/1481-cookie-consent-requirements-for-microsoft-clarity
Changes in this PR:
Add call to clarity API for consent