-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
clarity API cookie consent #7443
Conversation
app/helpers/application_helper.rb
Outdated
@@ -36,6 +36,7 @@ def footer_links | |||
end | |||
|
|||
def consented_to_extra_cookies? | |||
cookies["consented-to-additional-cookies-v2"] == "yes" && Rails.configuration.app_role.production? | |||
# consented value can be 'yes' or 'clarity' | |||
cookies["consented-to-additional-cookies-v2"] != "no" && Rails.configuration.app_role.production? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this check for "yes" || "clarity"
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I figured != 'no' was a better check for future proofing - but actually you're right, there is a potential bug here if the consented value isn't set.
Review app https://teaching-vacancies-review-pr-7443.test.teacherservices.cloud was successfully deleted |
Trello card URL
https://trello.com/c/aeXcAUxZ/1481-cookie-consent-requirements-for-microsoft-clarity
Changes in this PR:
Add call to clarity API for consent