Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

selective update from bay12 info #677

Merged
merged 10 commits into from
Nov 16, 2023
Merged

selective update from bay12 info #677

merged 10 commits into from
Nov 16, 2023

Conversation

ab9rf
Copy link
Member

@ab9rf ab9rf commented Nov 16, 2023

this PR updates several structures definitions with information from the headers provided to us by bay12

some infrequently used types have been renamed (most notably job_cancel, which is a research-only type at this point), while more frequently used types have had their bay12 names logged (as original-name when our DTD allows it, as a comment when it does not) without changing their names in dfhack. a couple of enums had NONE (-1) values that we did not previously have in our definitions

none of these changes should have any implications for existing code

Copy link
Contributor

The sizes of the following types have changed in this pull request. Please verify that this is intentional. Note that renamed types are not currently detected and will also be listed here.

Type Platform Previous size New size (this PR) Change
job_cancel linux64 152 0 -152
job_cancel windows64 152 0 -152
job_cancel_reason linux64 2 0 -2
job_cancel_reason windows64 2 0 -2
killjob_exception_type linux64 0 2 +2
killjob_exception_type windows64 0 2 +2
killjob_exceptionst linux64 0 152 +152
killjob_exceptionst windows64 0 152 +152
trade_good_purpose linux64 0 2 +2
trade_good_purpose windows64 0 2 +2

This is an automated comment. Please leave a reply if you think that the above information is incorrect.

@myk002 myk002 merged commit 45c4430 into DFHack:master Nov 16, 2023
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants