Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add enum-attr alert_type to announcement_type #691

Merged
merged 6 commits into from
Dec 27, 2023
Merged

Add enum-attr alert_type to announcement_type #691

merged 6 commits into from
Dec 27, 2023

Conversation

Bumber64
Copy link
Contributor

Add an enum-attr to announcement_type enum to retrieve the relevant announcement_alert_type enum associated with it. The relevant switch is found in FUN_14005e5f0(report *) for v50.11 win64 Steam.

ab9rf
ab9rf reviewed Dec 24, 2023
View reviewed changes
df.announcements.xml Outdated Show resolved Hide resolved
@myk002 myk002 merged commit 6e5926e into DFHack:master Dec 27, 2023
17 checks passed
@Bumber64 Bumber64 deleted the patch-3 branch December 27, 2023 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ab9rf ab9rf ab9rf left review comments

@myk002 myk002 myk002 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
50.11-r5
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Bumber64 @myk002 @ab9rf